From: James Hogan <james.hogan@imgtec.com>
To: Vince Weaver <vincent.weaver@maine.edu>, <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code
Date: Mon, 16 Jun 2014 15:56:58 +0100 [thread overview]
Message-ID: <539F05BA.7070004@imgtec.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1406150202050.16738@vincent-weaver-1.umelst.maine.edu>
Hi Vince,
On 15/06/14 07:03, Vince Weaver wrote:
>
> Transition to using the new generic PERF_PMU_CAP_NO_INTERRUPT method for
> failing a sampling event when no PMU interrupt is available.
>
> Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
> @@ -866,6 +856,15 @@ static int __init init_hw_perf_events(void)
> pr_info("enabled with %s PMU driver, %d counters available\n",
> metag_pmu->name, metag_pmu->max_events);
>
> + /*
> + * Early cores have "limited" counters - they have no overflow
> + * interrupts - and so are unable to do sampling without extra work
> + * and timer assistance.
> + */
> + if (metag_pmu->max_period == 0) {
> + metag_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;
> + }
The braces could be dropped.
Otherwise looks good to me,
Acked-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
next prev parent reply other threads:[~2014-06-16 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 6:03 [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code Vince Weaver
2014-06-16 14:56 ` James Hogan [this message]
2014-06-19 12:37 ` [tip:perf/core] metag, perf: " tip-bot for Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F05BA.7070004@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox