From: James Hogan <james.hogan@imgtec.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
<linux-metag@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch: metag: mm: hugetlbpage.c: Fix to remove null pointer checks that could never happen
Date: Mon, 16 Jun 2014 16:27:51 +0100 [thread overview]
Message-ID: <539F0CF7.7010108@imgtec.com> (raw)
In-Reply-To: <1401405118-11387-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 30/05/14 00:11, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Applied, thanks
James
> ---
> arch/metag/mm/hugetlbpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/metag/mm/hugetlbpage.c b/arch/metag/mm/hugetlbpage.c
> index 0424315..e89c843 100644
> --- a/arch/metag/mm/hugetlbpage.c
> +++ b/arch/metag/mm/hugetlbpage.c
> @@ -178,7 +178,7 @@ new_search:
> mm->context.part_huge = 0;
> return addr;
> }
> - if (vma && (vma->vm_flags & MAP_HUGETLB)) {
> + if ((vma->vm_flags & MAP_HUGETLB)) {
> /* space after a huge vma in 2nd level page table? */
> if (vma->vm_end & HUGEPT_MASK) {
> after_huge = 1;
>
prev parent reply other threads:[~2014-06-16 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 23:11 [PATCH] arch: metag: mm: hugetlbpage.c: Fix to remove null pointer checks that could never happen Rickard Strandqvist
2014-06-16 15:27 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F0CF7.7010108@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox