public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: metag: mm: hugetlbpage.c:  Fix to remove null pointer checks that could never happen
@ 2014-05-29 23:11 Rickard Strandqvist
  2014-06-16 15:27 ` James Hogan
  0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-05-29 23:11 UTC (permalink / raw)
  To: James Hogan, Rickard Strandqvist
  Cc: Andrew Morton, Naoya Horiguchi, linux-metag, linux-kernel

Removal of null pointer checks that could never happen

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/metag/mm/hugetlbpage.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/metag/mm/hugetlbpage.c b/arch/metag/mm/hugetlbpage.c
index 0424315..e89c843 100644
--- a/arch/metag/mm/hugetlbpage.c
+++ b/arch/metag/mm/hugetlbpage.c
@@ -178,7 +178,7 @@ new_search:
 				mm->context.part_huge = 0;
 			return addr;
 		}
-		if (vma && (vma->vm_flags & MAP_HUGETLB)) {
+		if ((vma->vm_flags & MAP_HUGETLB)) {
 			/* space after a huge vma in 2nd level page table? */
 			if (vma->vm_end & HUGEPT_MASK) {
 				after_huge = 1;
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arch: metag: mm: hugetlbpage.c:  Fix to remove null pointer checks that could never happen
  2014-05-29 23:11 [PATCH] arch: metag: mm: hugetlbpage.c: Fix to remove null pointer checks that could never happen Rickard Strandqvist
@ 2014-06-16 15:27 ` James Hogan
  0 siblings, 0 replies; 2+ messages in thread
From: James Hogan @ 2014-06-16 15:27 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Andrew Morton, Naoya Horiguchi, linux-metag, linux-kernel

On 30/05/14 00:11, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Applied, thanks
James

> ---
>  arch/metag/mm/hugetlbpage.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/metag/mm/hugetlbpage.c b/arch/metag/mm/hugetlbpage.c
> index 0424315..e89c843 100644
> --- a/arch/metag/mm/hugetlbpage.c
> +++ b/arch/metag/mm/hugetlbpage.c
> @@ -178,7 +178,7 @@ new_search:
>  				mm->context.part_huge = 0;
>  			return addr;
>  		}
> -		if (vma && (vma->vm_flags & MAP_HUGETLB)) {
> +		if ((vma->vm_flags & MAP_HUGETLB)) {
>  			/* space after a huge vma in 2nd level page table? */
>  			if (vma->vm_end & HUGEPT_MASK) {
>  				after_huge = 1;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-16 15:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-29 23:11 [PATCH] arch: metag: mm: hugetlbpage.c: Fix to remove null pointer checks that could never happen Rickard Strandqvist
2014-06-16 15:27 ` James Hogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox