* [PATCHv4]Checks for Null value in function *get_skub @ 2014-06-16 15:25 Nicholas Krause 2014-06-16 15:30 ` Steve Wise 0 siblings, 1 reply; 9+ messages in thread From: Nicholas Krause @ 2014-06-16 15:25 UTC (permalink / raw) To: swise; +Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- drivers/infiniband/hw/cxgb4/cm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f9477e2..2d56983 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -340,15 +340,13 @@ static int status2errno(int status) */ static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) { if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { skb_trim(skb, 0); skb_get(skb); skb_reset_transport_header(skb); } else { + if (skb) + kfree_skb (skb); skb = alloc_skb(len, gfp); } t4_set_arp_err_handler(skb, NULL, NULL); -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:25 [PATCHv4]Checks for Null value in function *get_skub Nicholas Krause @ 2014-06-16 15:30 ` Steve Wise 2014-06-16 15:33 ` Levente Kurusa 2014-06-16 15:37 ` Nick Krause 0 siblings, 2 replies; 9+ messages in thread From: Steve Wise @ 2014-06-16 15:30 UTC (permalink / raw) To: Nicholas Krause, swise Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel On 6/16/2014 10:25 AM, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index f9477e2..2d56983 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -340,15 +340,13 @@ static int status2errno(int status) > */ > static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) > { > if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { > skb_trim(skb, 0); > skb_get(skb); > skb_reset_transport_header(skb); > } else { > + if (skb) > + kfree_skb (skb); > skb = alloc_skb(len, gfp); > } > t4_set_arp_err_handler(skb, NULL, NULL); Can you change the comment? This patch is now fixing a potential skb leak. Also, kfree_sb() will ignore NULL ptrs, so we could just always call it. But I'd add a comment like /* NULL is ignored */. Thanks, Steve. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:30 ` Steve Wise @ 2014-06-16 15:33 ` Levente Kurusa 2014-06-16 15:37 ` Nick Krause 1 sibling, 0 replies; 9+ messages in thread From: Levente Kurusa @ 2014-06-16 15:33 UTC (permalink / raw) To: Steve Wise, Nicholas Krause, swise Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel On 06/16/2014 05:30 PM, Steve Wise wrote: > On 6/16/2014 10:25 AM, Nicholas Krause wrote: >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> drivers/infiniband/hw/cxgb4/cm.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c >> index f9477e2..2d56983 100644 >> --- a/drivers/infiniband/hw/cxgb4/cm.c >> +++ b/drivers/infiniband/hw/cxgb4/cm.c >> @@ -340,15 +340,13 @@ static int status2errno(int status) >> */ >> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) >> { >> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >> skb_trim(skb, 0); >> skb_get(skb); >> skb_reset_transport_header(skb); >> } else { >> + if (skb) >> + kfree_skb (skb); >> skb = alloc_skb(len, gfp); >> } >> t4_set_arp_err_handler(skb, NULL, NULL); > > Can you change the comment? This patch is now fixing a potential skb leak. > Also, kfree_sb() will ignore NULL ptrs, so we could just always call it. > But I'd add a comment like /* NULL is ignored */. AFAIK, checkpatch.pl will show you a message if it detects this: if (x) kfree(x); so I guess it is not really needed. Thanks, Levente Kurusa. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:30 ` Steve Wise 2014-06-16 15:33 ` Levente Kurusa @ 2014-06-16 15:37 ` Nick Krause 2014-06-16 15:45 ` Nick Krause 2014-06-16 15:45 ` Levente Kurusa 1 sibling, 2 replies; 9+ messages in thread From: Nick Krause @ 2014-06-16 15:37 UTC (permalink / raw) To: Steve Wise Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- drivers/infiniband/hw/cxgb4/ cm.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f9477e2..2d56983 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -340,15 +340,13 @@ static int status2errno(int status) */ static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) { if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { skb_trim(skb, 0); skb_get(skb); skb_reset_transport_header(skb); } else { + if (skb) /* NULL is ignored */. + kfree_skb (skb); skb = alloc_skb(len, gfp); } t4_set_arp_err_handler(skb, NULL, NULL); On Mon, Jun 16, 2014 at 11:30 AM, Steve Wise <swise@opengridcomputing.com> wrote: > On 6/16/2014 10:25 AM, Nicholas Krause wrote: >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> drivers/infiniband/hw/cxgb4/cm.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb4/cm.c >> b/drivers/infiniband/hw/cxgb4/cm.c >> index f9477e2..2d56983 100644 >> --- a/drivers/infiniband/hw/cxgb4/cm.c >> +++ b/drivers/infiniband/hw/cxgb4/cm.c >> @@ -340,15 +340,13 @@ static int status2errno(int status) >> */ >> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) >> { >> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >> skb_trim(skb, 0); >> skb_get(skb); >> skb_reset_transport_header(skb); >> } else { >> + if (skb) >> + kfree_skb (skb); >> skb = alloc_skb(len, gfp); >> } >> t4_set_arp_err_handler(skb, NULL, NULL); > > > Can you change the comment? This patch is now fixing a potential skb leak. > Also, kfree_sb() will ignore NULL ptrs, so we could just always call it. > But I'd add a comment like /* NULL is ignored */. > > Thanks, > > Steve. ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:37 ` Nick Krause @ 2014-06-16 15:45 ` Nick Krause 2014-06-16 17:18 ` Steve Wise 2014-06-16 15:45 ` Levente Kurusa 1 sibling, 1 reply; 9+ messages in thread From: Nick Krause @ 2014-06-16 15:45 UTC (permalink / raw) To: Steve Wise Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel Can we close this bug or is it still a issue as we can' return NULL from kfree or kfree_skb. Here is the bug ID 44631 I would close it if we are done with the bug otherwise I think there are no other issues with allocating a skb, Cheers Nick On Mon, Jun 16, 2014 at 11:37 AM, Nick Krause <xerofoify@gmail.com> wrote: > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/infiniband/hw/cxgb4/ > cm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index f9477e2..2d56983 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -340,15 +340,13 @@ static int status2errno(int status) > */ > static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) > { > if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { > skb_trim(skb, 0); > skb_get(skb); > skb_reset_transport_header(skb); > } else { > + if (skb) > /* NULL is ignored */. > + kfree_skb (skb); > skb = alloc_skb(len, gfp); > } > t4_set_arp_err_handler(skb, NULL, NULL); > > On Mon, Jun 16, 2014 at 11:30 AM, Steve Wise > <swise@opengridcomputing.com> wrote: >> On 6/16/2014 10:25 AM, Nicholas Krause wrote: >>> >>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >>> --- >>> drivers/infiniband/hw/cxgb4/cm.c | 8 +++----- >>> 1 file changed, 3 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c >>> b/drivers/infiniband/hw/cxgb4/cm.c >>> index f9477e2..2d56983 100644 >>> --- a/drivers/infiniband/hw/cxgb4/cm.c >>> +++ b/drivers/infiniband/hw/cxgb4/cm.c >>> @@ -340,15 +340,13 @@ static int status2errno(int status) >>> */ >>> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) >>> { >>> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >>> skb_trim(skb, 0); >>> skb_get(skb); >>> skb_reset_transport_header(skb); >>> } else { >>> + if (skb) >>> + kfree_skb (skb); >>> skb = alloc_skb(len, gfp); >>> } >>> t4_set_arp_err_handler(skb, NULL, NULL); >> >> >> Can you change the comment? This patch is now fixing a potential skb leak. >> Also, kfree_sb() will ignore NULL ptrs, so we could just always call it. >> But I'd add a comment like /* NULL is ignored */. >> >> Thanks, >> >> Steve. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:45 ` Nick Krause @ 2014-06-16 17:18 ` Steve Wise 0 siblings, 0 replies; 9+ messages in thread From: Steve Wise @ 2014-06-16 17:18 UTC (permalink / raw) To: Nick Krause Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel On 6/16/2014 10:45 AM, Nick Krause wrote: > Can we close this bug or is it still a issue as we can' > return NULL from kfree or kfree_skb. Here is the bug > ID 44631 I would close it if we are done with the bug > otherwise I think there are no other issues with > allocating a skb, > In what database is this bug ID 44631? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:37 ` Nick Krause 2014-06-16 15:45 ` Nick Krause @ 2014-06-16 15:45 ` Levente Kurusa 2014-06-16 16:32 ` Nick Krause 2014-06-16 16:37 ` Steve Wise 1 sibling, 2 replies; 9+ messages in thread From: Levente Kurusa @ 2014-06-16 15:45 UTC (permalink / raw) To: Nick Krause, Steve Wise Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel On 06/16/2014 05:37 PM, Nick Krause wrote: > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/infiniband/hw/cxgb4/ > cm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index f9477e2..2d56983 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -340,15 +340,13 @@ static int status2errno(int status) > */ > static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) > { > if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { > skb_trim(skb, 0); > skb_get(skb); > skb_reset_transport_header(skb); > } else { > + if (skb) > /* NULL is ignored */. > + kfree_skb (skb); > skb = alloc_skb(len, gfp); > } > t4_set_arp_err_handler(skb, NULL, NULL); This patch is severely whitespace damaged. Can you fix your MUA or try to use git-send-email? The changelog as well is of low quality. Maybe something like this: infiniband: cxgb4: fix memory skb memory leak ... would be better. Also, this fails the build, due to the extra dot character after the comment. :-( Thanks, Levente Kurusa. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:45 ` Levente Kurusa @ 2014-06-16 16:32 ` Nick Krause 2014-06-16 16:37 ` Steve Wise 1 sibling, 0 replies; 9+ messages in thread From: Nick Krause @ 2014-06-16 16:32 UTC (permalink / raw) To: Levente Kurusa Cc: Steve Wise, swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel Hey Guys , It states tot run cleanfile or cleanpatch script but it doesn't work how do I run these scripts. Thanks Nick On Mon, Jun 16, 2014 at 11:45 AM, Levente Kurusa <levex@linux.com> wrote: > On 06/16/2014 05:37 PM, Nick Krause wrote: >> >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> drivers/infiniband/hw/cxgb4/ >> cm.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb4/cm.c >> b/drivers/infiniband/hw/cxgb4/cm.c >> index f9477e2..2d56983 100644 >> --- a/drivers/infiniband/hw/cxgb4/cm.c >> +++ b/drivers/infiniband/hw/cxgb4/cm.c >> @@ -340,15 +340,13 @@ static int status2errno(int status) >> */ >> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp) >> { >> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >> skb_trim(skb, 0); >> skb_get(skb); >> skb_reset_transport_header(skb); >> } else { >> + if (skb) >> /* NULL is ignored */. >> + kfree_skb (skb); >> skb = alloc_skb(len, gfp); >> } >> t4_set_arp_err_handler(skb, NULL, NULL); > > > This patch is severely whitespace damaged. Can you fix your MUA > or try to use git-send-email? > > The changelog as well is of low quality. Maybe something like this: > > infiniband: cxgb4: fix memory skb memory leak > > ... would be better. > > Also, this fails the build, due to the extra dot character after > the comment. :-( > > Thanks, > Levente Kurusa. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCHv4]Checks for Null value in function *get_skub 2014-06-16 15:45 ` Levente Kurusa 2014-06-16 16:32 ` Nick Krause @ 2014-06-16 16:37 ` Steve Wise 1 sibling, 0 replies; 9+ messages in thread From: Steve Wise @ 2014-06-16 16:37 UTC (permalink / raw) To: Levente Kurusa, Nick Krause Cc: swise, roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel On 6/16/2014 10:45 AM, Levente Kurusa wrote: > On 06/16/2014 05:37 PM, Nick Krause wrote: >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >> --- >> drivers/infiniband/hw/cxgb4/ >> cm.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/infiniband/hw/cxgb4/cm.c >> b/drivers/infiniband/hw/cxgb4/cm.c >> index f9477e2..2d56983 100644 >> --- a/drivers/infiniband/hw/cxgb4/cm.c >> +++ b/drivers/infiniband/hw/cxgb4/cm.c >> @@ -340,15 +340,13 @@ static int status2errno(int status) >> */ >> static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t >> gfp) >> { >> if (skb && !skb_is_nonlinear(skb) && !skb_cloned(skb)) { >> skb_trim(skb, 0); >> skb_get(skb); >> skb_reset_transport_header(skb); >> } else { >> + if (skb) >> /* NULL is ignored */. >> + kfree_skb (skb); >> skb = alloc_skb(len, gfp); >> } >> t4_set_arp_err_handler(skb, NULL, NULL); > > This patch is severely whitespace damaged. Can you fix your MUA > or try to use git-send-email? > > The changelog as well is of low quality. Maybe something like this: > > infiniband: cxgb4: fix memory skb memory leak > > ... would be better. > > Also, this fails the build, due to the extra dot character after > the comment. :-( > Agreed. Start over with this patch, do what we asked, and make sure it passes checkpatch... > Thanks, > Levente Kurusa. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-06-16 17:18 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-16 15:25 [PATCHv4]Checks for Null value in function *get_skub Nicholas Krause 2014-06-16 15:30 ` Steve Wise 2014-06-16 15:33 ` Levente Kurusa 2014-06-16 15:37 ` Nick Krause 2014-06-16 15:45 ` Nick Krause 2014-06-16 17:18 ` Steve Wise 2014-06-16 15:45 ` Levente Kurusa 2014-06-16 16:32 ` Nick Krause 2014-06-16 16:37 ` Steve Wise
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox