From: Steve Wise <swise@opengridcomputing.com>
To: Nicholas Krause <xerofoify@gmail.com>, swise@chelsio.com
Cc: roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc
Date: Mon, 16 Jun 2014 13:18:16 -0500 [thread overview]
Message-ID: <539F34E8.3000501@opengridcomputing.com> (raw)
In-Reply-To: <1402940957-6381-1-git-send-email-xerofoify@gmail.com>
On 6/16/2014 12:49 PM, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 5e153f6..867e664 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -455,8 +455,11 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
> unsigned int flowclen = 80;
> struct fw_flowc_wr *flowc;
> int i;
> -
Please add back the above blank line.
> skb = get_skb(skb, flowclen, GFP_KERNEL);
> + if (!skb) {
> + kfree_skb(skb);
Let's do a pr_warn() here;
pr_warn(MOD "%s failed to allocate skb.\n", __func__);
> + return;
> + }
> flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen);
>
> flowc->op_to_nparams = cpu_to_be32(FW_WR_OP(FW_FLOWC_WR) |
next prev parent reply other threads:[~2014-06-16 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 17:49 [PATCH] infiniband: Fixes memory leak in send_flowc Nicholas Krause
2014-06-16 18:18 ` Steve Wise [this message]
2014-06-16 23:44 ` David Rientjes
[not found] ` <CAPDOMVg8hT95Wcmy4VHdfsumEvc=w3dz8V8xP1QScsLK3buSxw@mail.gmail.com>
2014-06-17 0:09 ` David Rientjes
[not found] ` <CAPDOMVjjwywH36guWC2q-Y26m-DEoHHJtk5Vasvk2kfsDpCuiA@mail.gmail.com>
2014-06-17 0:36 ` David Rientjes
2014-06-17 13:53 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F34E8.3000501@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox