Re: [PATCHv2 0/2] regulator: of: Add support for pasing regulator suspend state

[Chanwoo Choi <cw00.choi@samsung.com>]

Hi Mark,

Could you please review this patchset?

Best Regards,
Chanwoo Choi

On 06/11/2014 09:41 AM, Chanwoo Choi wrote:
> The regulators would set different state/mode according to the kind of suspend
> state. So regulation_constraints structure has already regulator suspend state filed.
> This patch parse regulator suspend state from devicetree file.
> 
> For example:
> 
> 	ldoX_reg: LDOx {
> 		regulator-name = "VAP_XXX_1.2V";
> 		regulator-min-microvolt = <1200000>;
> 		regulator-max-microvolt = <1200000>;
> 		regulator-always-on;
> 
> 		regulator-initial-state = <3>;	/* PM_SUSPEND_MEM */
> 		regulator-state-standby {
> 			regulator-volt = <1200000>;
> 			regulator-mode = <0x2>;	/* REGULATOR_MODE_NORMAL */
> 		};
> 
> 		regulator-state-mem {
> 			regulator-volt = <1200000>;
> 			regulator-mode = <0x8>;	/* REGULATOR_MODE_STANDBY */
> 			regulator-off-in-suspend;
> 		};
> 
> 		regulator-state-disk {
> 			regulator-volt = <1200000>;
> 			regulator-mode = <0x2>;	/* REGULATOR_MODE_NORMAL */
> 			regulator-on-in-suspend;
> 		};
> 	};
> 
> Changes from v1:
> - Check whether regulator-initial-state and regulator-mode is correct or not
> - Add more detailed description about regulator-initial-state, regulator-mode
>   and regulator-state-[standby/mem/disk] for devicetree bindings
> - Modify example of regulator suspend state in bindings documentation
> 
> Chanwoo Choi (2):
>   regulator: of: Add support for parsing regulator_state for suspend state
>   dt-bindings: regulator: Add regulator suspend state for PM state
> 
>  .../devicetree/bindings/regulator/regulator.txt    | 32 +++++++++
>  drivers/regulator/of_regulator.c                   | 76 +++++++++++++++++++++-
>  2 files changed, 106 insertions(+), 2 deletions(-)
>