* [PATCH] Fix comments in rbtree.c
@ 2014-06-14 18:34 Nick
2014-06-17 3:59 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Nick @ 2014-06-14 18:34 UTC (permalink / raw)
To: cody; +Cc: akpm, sjenning, linux-kernel
Signed-off-by: Nick <xerofoify@gmail.com>
---
lib/rbtree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/rbtree.c b/lib/rbtree.c
index 65f4eff..c66370c 100644
--- a/lib/rbtree.c
+++ b/lib/rbtree.c
@@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
* / \ / \
* p u --> P U
* / /
- * n N
+ * n n
*
* However, since g's parent might be red, and
* 4) does not allow this, we need to recurse
- * at g.
*/
rb_set_parent_color(tmp, gparent, RB_BLACK);
rb_set_parent_color(parent, gparent, RB_BLACK);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix comments in rbtree.c
2014-06-14 18:34 [PATCH] Fix comments in rbtree.c Nick
@ 2014-06-17 3:59 ` Guenter Roeck
2014-07-08 16:29 ` Fwd: " Nick Krause
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2014-06-17 3:59 UTC (permalink / raw)
To: Nick, cody; +Cc: akpm, sjenning, linux-kernel
On 06/14/2014 11:34 AM, Nick wrote:
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> lib/rbtree.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/rbtree.c b/lib/rbtree.c
> index 65f4eff..c66370c 100644
> --- a/lib/rbtree.c
> +++ b/lib/rbtree.c
> @@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
> * / \ / \
> * p u --> P U
> * / /
> - * n N
> + * n n
You'll need a lengthy explanation here. What makes you think that the comment
is wrong ?
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Fwd: [PATCH] Fix comments in rbtree.c
2014-06-17 3:59 ` Guenter Roeck
@ 2014-07-08 16:29 ` Nick Krause
0 siblings, 0 replies; 3+ messages in thread
From: Nick Krause @ 2014-07-08 16:29 UTC (permalink / raw)
To: Guenter Roeck, cody; +Cc: Andrew Morton, sjenning, linux-kernel@vger.kernel.org
From: Guenter Roeck wrote on Mon, Jun 16, 2014 at 11:59 PM
Subject: Re: [PATCH] Fix comments in rbtree.c
To: Nick <xerofoify@gmail.com>, cody@linux.vnet.ibm.com
Cc: akpm@linux-foundation.org, sjenning@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org
On 06/14/2014 11:34 AM, Nick wrote:
>
> Signed-off-by: Nick <xerofoify@gmail.com>
> ---
> lib/rbtree.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/rbtree.c b/lib/rbtree.c
> index 65f4eff..c66370c 100644
> --- a/lib/rbtree.c
> +++ b/lib/rbtree.c
> @@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
> * / \ / \
> * p u --> P U
> * / /
> - * n N
> + * n n
You'll need a lengthy explanation here. What makes you think that the comment
is wrong ?
Guenter
This seems right as of rereading my patch I sent to you. You can drop
this patch.
Cheers Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-08 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-14 18:34 [PATCH] Fix comments in rbtree.c Nick
2014-06-17 3:59 ` Guenter Roeck
2014-07-08 16:29 ` Fwd: " Nick Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox