* [PATCH v5 1/8] staging: lustre: lclient: glimpse.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 2/8] " Anil Belur
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)"
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/staging/lustre/lustre/lclient/glimpse.c
index 7bbca4b..f669645 100644
--- a/drivers/staging/lustre/lustre/lclient/glimpse.c
+++ b/drivers/staging/lustre/lustre/lclient/glimpse.c
@@ -177,7 +177,7 @@ static int cl_io_get(struct inode *inode, struct lu_env **envout,
io->ci_obj = clob;
*envout = env;
*ioout = io;
- result = +1;
+ result = 1;
} else
result = PTR_ERR(env);
} else
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 2/8] staging: lustre: lclient: glimpse.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
2014-06-16 16:22 ` [PATCH v5 1/8] staging: lustre: lclient: glimpse.c " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 3/8] staging: lustre: lclient: lcommon_misc.c " Anil Belur
` (5 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed "WARNING: labels should not be indented"
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/staging/lustre/lustre/lclient/glimpse.c
index f669645..a658116 100644
--- a/drivers/staging/lustre/lustre/lclient/glimpse.c
+++ b/drivers/staging/lustre/lustre/lclient/glimpse.c
@@ -204,7 +204,7 @@ int cl_glimpse_size0(struct inode *inode, int agl)
result = cl_io_get(inode, &env, &io, &refcheck);
if (result > 0) {
- again:
+again:
io->ci_verify_layout = 1;
result = cl_io_init(env, io, CIT_MISC, io->ci_obj);
if (result > 0)
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
2014-06-16 16:22 ` [PATCH v5 1/8] staging: lustre: lclient: glimpse.c " Anil Belur
2014-06-16 16:22 ` [PATCH v5 2/8] " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 4/8] staging: lustre: lclient: lcommon_cl.c " Anil Belur
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed warning:
* WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count,
LOV_MAX_STRIPE_COUNT)
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
index e04c2d3..01ce5c1 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c
@@ -63,7 +63,7 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp)
if (rc)
return rc;
- stripes = min(desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT);
+ stripes = min_t(__u32, desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT);
lsm.lsm_stripe_count = stripes;
easize = obd_size_diskmd(dt_exp, &lsm);
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 4/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
` (2 preceding siblings ...)
2014-06-16 16:22 ` [PATCH v5 3/8] staging: lustre: lclient: lcommon_misc.c " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 5/8] " Anil Belur
` (3 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed: WARNING: Missing a blank line after declarations
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index 6907a16..f83e6f2 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -127,6 +127,7 @@ void ccc_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct ccc_thread_info *info = data;
+
OBD_SLAB_FREE_PTR(info, ccc_thread_kmem);
}
@@ -145,6 +146,7 @@ void ccc_session_key_fini(const struct lu_context *ctx,
struct lu_context_key *key, void *data)
{
struct ccc_session *session = data;
+
OBD_SLAB_FREE_PTR(session, ccc_session_kmem);
}
@@ -573,6 +575,7 @@ void ccc_lock_delete(const struct lu_env *env,
void ccc_lock_fini(const struct lu_env *env, struct cl_lock_slice *slice)
{
struct ccc_lock *clk = cl2ccc_lock(slice);
+
OBD_SLAB_FREE_PTR(clk, ccc_lock_kmem);
}
@@ -753,6 +756,7 @@ int ccc_io_one_lock(const struct lu_env *env, struct cl_io *io,
loff_t start, loff_t end)
{
struct cl_object *obj = io->ci_obj;
+
return ccc_io_one_lock_index(env, io, enqflags, mode,
cl_index(obj, start), cl_index(obj, end));
}
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 5/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
` (3 preceding siblings ...)
2014-06-16 16:22 ` [PATCH v5 4/8] staging: lustre: lclient: lcommon_cl.c " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 6/8] " Anil Belur
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed: ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index f83e6f2..7be0a93 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -267,7 +267,7 @@ int ccc_req_init(const struct lu_env *env, struct cl_device *dev,
* fails. Access to this environment is serialized by ccc_inode_fini_guard
* mutex.
*/
-static struct lu_env *ccc_inode_fini_env = NULL;
+static struct lu_env *ccc_inode_fini_env;
/**
* A mutex serializing calls to slp_inode_fini() under extreme memory
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 6/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
` (4 preceding siblings ...)
2014-06-16 16:22 ` [PATCH v5 5/8] " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-16 16:22 ` [PATCH v5 7/8] " Anil Belur
2014-06-16 16:22 ` [PATCH v5 8/8] " Anil Belur
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed: ERROR: inline keyword should sit between storage class and type
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index 7be0a93..c180a20 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -1316,7 +1316,7 @@ struct lov_stripe_md *ccc_inode_lsm_get(struct inode *inode)
return lov_lsm_get(cl_i2info(inode)->lli_clob);
}
-void inline ccc_inode_lsm_put(struct inode *inode, struct lov_stripe_md *lsm)
+inline void ccc_inode_lsm_put(struct inode *inode, struct lov_stripe_md *lsm)
{
lov_lsm_put(cl_i2info(inode)->lli_clob, lsm);
}
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v5 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
` (5 preceding siblings ...)
2014-06-16 16:22 ` [PATCH v5 6/8] " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
2014-06-17 2:08 ` Drokin, Oleg
2014-06-16 16:22 ` [PATCH v5 8/8] " Anil Belur
7 siblings, 1 reply; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
store the offset. Replace "unsigned long" with "u64" type for
'cur_index'
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index c180a20..6c5b828 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -864,10 +864,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
* linux-2.6.18-128.1.1 miss to do that.
* --bug 17336 */
loff_t size = cl_isize_read(inode);
- unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
+ loff_t cur_index = start >> PAGE_CACHE_SHIFT;
+ loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);
if ((size == 0 && cur_index != 0) ||
- (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index))
+ (size_index < cur_index))
*exceed = 1;
}
return result;
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v5 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 ` [PATCH v5 7/8] " Anil Belur
@ 2014-06-17 2:08 ` Drokin, Oleg
2014-06-17 4:56 ` Anil Shashikumar Belur
0 siblings, 1 reply; 11+ messages in thread
From: Drokin, Oleg @ 2014-06-17 2:08 UTC (permalink / raw)
To: Anil Belur
Cc: Dilger, Andreas, <tao.peng@emc.com>,
<gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
<hpdd-discuss@lists.01.org>
On Jun 16, 2014, at 12:22 PM, Anil Belur wrote:
> From: Anil Belur <askb23@gmail.com>
>
> fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
> store the offset. Replace "unsigned long" with "u64" type for
Apparently you forgot to update the comment.
> 'cur_index'
>
> Signed-off-by: Anil Belur <askb23@gmail.com>
> ---
> drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index c180a20..6c5b828 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -864,10 +864,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
> * linux-2.6.18-128.1.1 miss to do that.
> * --bug 17336 */
> loff_t size = cl_isize_read(inode);
> - unsigned long cur_index = start >> PAGE_CACHE_SHIFT;
> + loff_t cur_index = start >> PAGE_CACHE_SHIFT;
> + loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);
>
> if ((size == 0 && cur_index != 0) ||
> - (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index))
> + (size_index < cur_index))
> *exceed = 1;
> }
> return result;
> --
> 1.9.0
>
Bye,
Oleg
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v5 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-17 2:08 ` Drokin, Oleg
@ 2014-06-17 4:56 ` Anil Shashikumar Belur
0 siblings, 0 replies; 11+ messages in thread
From: Anil Shashikumar Belur @ 2014-06-17 4:56 UTC (permalink / raw)
To: Drokin, Oleg
Cc: Dilger, Andreas, <tao.peng@emc.com>,
<gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
<hpdd-discuss@lists.01.org>
On Tuesday 17 June 2014 07:38 AM, Drokin, Oleg wrote:
> On Jun 16, 2014, at 12:22 PM, Anil Belur wrote:
>
>> From: Anil Belur <askb23@gmail.com>
>>
>> fixed: WARNING: line over 80 characters, used a new variable 'size_index' to
>> store the offset. Replace "unsigned long" with "u64" type for
> Apparently you forgot to update the comment.
Thanks Oleg - overlooked it, will fix this shortly.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5 8/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
2014-06-16 16:22 [PATCH v5] staging: lustre: lclient: fixing coding style issues Anil Belur
` (6 preceding siblings ...)
2014-06-16 16:22 ` [PATCH v5 7/8] " Anil Belur
@ 2014-06-16 16:22 ` Anil Belur
7 siblings, 0 replies; 11+ messages in thread
From: Anil Belur @ 2014-06-16 16:22 UTC (permalink / raw)
To: andreas.dilger, oleg.drokin, tao.peng, gregkh
Cc: linux-kernel, hpdd-discuss, Anil Belur
From: Anil Belur <askb23@gmail.com>
fixed: WARNING: suspect code indent for conditional statements (32, 32)
Signed-off-by: Anil Belur <askb23@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index 6c5b828..1bf6404 100644
--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
@@ -868,8 +868,8 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT);
if ((size == 0 && cur_index != 0) ||
- (size_index < cur_index))
- *exceed = 1;
+ (size_index < cur_index))
+ *exceed = 1;
}
return result;
} else {
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread