Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

Mark Brown
2014-06-16T19:27:45Z

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Mon, Jun 16, 2014 at 08:02:34PM +0200, Javier Martinez Canillas wrote:

> +- max77802,pmic-buck-dvs-gpios: The DVS GPIOs. We'll try to set these GPIOs
> + to match pmic-buck-default-dvs-idx at probe time if they are defined. If
> + some or all of these GPIOs are not defined it's assumed that the board has
> + any missing GPIOs hardwired to match pmic-buck-default-dvs-idx.

I can't tell from reading this what the property means exactly - I
expect it is an array of the GPIOs in some order but that order isn't
specified.

> +config MFD_MAX77802
> + tristate "Maxim Integrated MAX77802 PMIC Support"
> + depends on I2C=y
> + select MFD_CORE
> + select REGMAP_I2C
> + select REGMAP_IRQ
> + select IRQ_DOMAIN
> + help
> + Say yes here to support for Maxim Integrated MAX77802.
> + This is a Power Management IC with RTC on chip.
> + This driver provides common support for accessing the device;
> + additional drivers must be enabled in order to use the functionality
> + of the device.
> +

It is a bit unorthodox to put the build infrastructure in the same patch
as the DT binding...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]