From: Jeff Liu <jeff.liu@oracle.com>
To: gregkh@linuxfoundation.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 15/24] drivers/of: return actual error on of_init
Date: Tue, 17 Jun 2014 22:30:38 +0800 [thread overview]
Message-ID: <53A0510E.1010909@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Return the actual error code if call kset_create_and_add() failed
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8368d96..8f8efa1 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -290,9 +290,9 @@ static int __init of_init(void)
/* Create the kset, and register existing nodes */
mutex_lock(&of_aliases_mutex);
of_kset = kset_create_and_add("devicetree", NULL, firmware_kobj);
- if (!of_kset) {
+ if (IS_ERR(of_kset)) {
mutex_unlock(&of_aliases_mutex);
- return -ENOMEM;
+ return PTR_ERR(of_kset);
}
for_each_of_allnodes(np)
__of_node_add(np);
--
1.8.3.2
next reply other threads:[~2014-06-17 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:30 Jeff Liu [this message]
2014-06-17 19:22 ` [PATCH 15/24] drivers/of: return actual error on of_init Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A0510E.1010909@oracle.com \
--to=jeff.liu@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox