* [PATCH 15/24] drivers/of: return actual error on of_init
@ 2014-06-17 14:30 Jeff Liu
2014-06-17 19:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Liu @ 2014-06-17 14:30 UTC (permalink / raw)
To: gregkh; +Cc: LKML
From: Jie Liu <jeff.liu@oracle.com>
Return the actual error code if call kset_create_and_add() failed
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8368d96..8f8efa1 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -290,9 +290,9 @@ static int __init of_init(void)
/* Create the kset, and register existing nodes */
mutex_lock(&of_aliases_mutex);
of_kset = kset_create_and_add("devicetree", NULL, firmware_kobj);
- if (!of_kset) {
+ if (IS_ERR(of_kset)) {
mutex_unlock(&of_aliases_mutex);
- return -ENOMEM;
+ return PTR_ERR(of_kset);
}
for_each_of_allnodes(np)
__of_node_add(np);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 15/24] drivers/of: return actual error on of_init
2014-06-17 14:30 [PATCH 15/24] drivers/of: return actual error on of_init Jeff Liu
@ 2014-06-17 19:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-06-17 19:22 UTC (permalink / raw)
To: Jeff Liu; +Cc: LKML
On Tue, Jun 17, 2014 at 10:30:38PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Return the actual error code if call kset_create_and_add() failed
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
> drivers/of/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Nope, not taking this, sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-17 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 14:30 [PATCH 15/24] drivers/of: return actual error on of_init Jeff Liu
2014-06-17 19:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox