From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>, Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>
Subject: Re: [PATCH 1/1] scripts/coccinelle/free: add conditional kfree test
Date: Tue, 17 Jun 2014 22:45:49 +0200 [thread overview]
Message-ID: <53A0A8FD.7080505@users.sourceforge.net> (raw)
In-Reply-To: <1403035539.2722.3.camel@joe-AO725>
>> This patch adds a trivial script warning on
>>
>> if(foo)
>> kfree(foo)
[...]
> You should probably add all of the unnecessary
> conditional tests that checkpatch uses:
[...]
Would you like to look at my previous update suggestion "Deletion of unnecessary
checks before specific function calls" again?
https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html
https://lkml.org/lkml/2014/3/5/344
Regards,
Markus
next prev parent reply other threads:[~2014-06-17 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:43 [PATCH 1/1] scripts/coccinelle/free: add conditional kfree test Fabian Frederick
2014-06-17 20:05 ` Joe Perches
2014-06-17 20:45 ` SF Markus Elfring [this message]
2014-06-17 21:33 ` Julia Lawall
2014-06-17 21:58 ` Joe Perches
2014-06-18 5:25 ` Julia Lawall
2014-06-18 5:45 ` Joe Perches
2014-06-18 9:02 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A0A8FD.7080505@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=fabf@skynet.be \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox