From: Anil Shashikumar Belur <askb23@gmail.com>
To: "Dilger, Andreas" <andreas.dilger@intel.com>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpdd-discuss@lists.01.org" <hpdd-discuss@ml01.01.org>
Subject: Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
Date: Wed, 18 Jun 2014 08:24:57 +0530 [thread overview]
Message-ID: <53A0FF81.6090405@gmail.com> (raw)
In-Reply-To: <CFC5C64E.ABDAF%andreas.dilger@intel.com>
> Should be an empty line between variable declarations and code.
Hi Andreas, not sure if you are referring to the same patch as there is
already an empty line present.
823 loff_t size = cl_isize_read(inode);
824 loff_t cur_index = start >>
PAGE_CACHE_SHIFT;
825 loff_t size_index = ((size - 1) >>
PAGE_CACHE_SHIFT);
826
827 if ((size == 0 && cur_index != 0) ||
Cheers,
Anil
next prev parent reply other threads:[~2014-06-18 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 5:43 [PATCH v6] staging: lustre: lclient: fixing coding style issues Anil Belur
2014-06-17 5:43 ` [PATCH v6 1/8] staging: lustre: lclient: glimpse.c " Anil Belur
2014-06-17 5:43 ` [PATCH v6 2/8] " Anil Belur
2014-06-17 5:43 ` [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c " Anil Belur
2014-06-17 16:15 ` Dilger, Andreas
2014-06-18 2:54 ` Anil Shashikumar Belur
2014-06-17 5:43 ` [PATCH v6 4/8] staging: lustre: lclient: lcommon_cl.c " Anil Belur
2014-06-17 5:43 ` [PATCH v6 5/8] " Anil Belur
2014-06-17 5:43 ` [PATCH v6 6/8] " Anil Belur
2014-06-17 5:43 ` [PATCH v6 7/8] " Anil Belur
2014-06-17 16:23 ` Dilger, Andreas
2014-06-18 2:54 ` Anil Shashikumar Belur [this message]
2014-06-17 5:43 ` [PATCH v6 8/8] " Anil Belur
2014-06-17 16:25 ` Dilger, Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A0FF81.6090405@gmail.com \
--to=askb23@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpdd-discuss@ml01.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox