From: Jens Axboe <axboe@kernel.dk>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH 0/3] blk-mq: bitmap tag: Fix few races
Date: Tue, 17 Jun 2014 20:12:20 -0700 [thread overview]
Message-ID: <53A10394.3010701@kernel.dk> (raw)
In-Reply-To: <20140617173956.GB361@dhcp-26-207.brq.redhat.com>
On 2014-06-17 10:39, Alexander Gordeev wrote:
> On Tue, Jun 17, 2014 at 07:21:19AM -0600, Jens Axboe wrote:
>> On 2014-06-17 04:35, Christoph Hellwig wrote:
>>> Jens, did you plan to pick these up? There's a few bits of low hanging
>>> fruit for cleanups / micro-optimizations in this area, but I don't want
>>> to create conflicts with Alexanders work.
>>
>> I'm evaluating just getting rid of the cyclic waits, which is why
>> I've held off. But the patches don't apply to the current tree
>> anyway, so they would need a rediffing no matter what.
>
> Hi Jens,
>
> Patches 1/3 and 2/3 apply to Linus's tree and could go in without patch 3/3.
> I'll post v2 of 3/3.
As mentioned in another thread, I'm sort-of hoping we can just get rid
of the nasty multiple waitqueues. Will run some testing when I'm back.
If we still see a nice gain of having the cycling waitqueues, then I'll
test and apply your patches to close up the holes.
--
Jens Axboe
prev parent reply other threads:[~2014-06-18 3:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 15:05 [PATCH 0/3] blk-mq: bitmap tag: Fix few races Alexander Gordeev
2014-06-12 15:05 ` [PATCH 1/3] blk-mq: bitmap tag: fix races on shared ::wake_index fields Alexander Gordeev
2014-06-12 15:05 ` [PATCH 2/3] blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt Alexander Gordeev
2014-06-12 15:05 ` [PATCH 3/3] blk-mq: bitmap tag: clean-up bt_get() function Alexander Gordeev
2014-06-17 10:35 ` [PATCH 0/3] blk-mq: bitmap tag: Fix few races Christoph Hellwig
2014-06-17 13:21 ` Jens Axboe
2014-06-17 17:39 ` Alexander Gordeev
2014-06-17 20:37 ` [PATCH v2 3/3] blk-mq: bitmap tag: fix races in bt_get() function Alexander Gordeev
2014-06-18 3:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A10394.3010701@kernel.dk \
--to=axboe@kernel.dk \
--cc=agordeev@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox