From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932083AbaFREyz (ORCPT ); Wed, 18 Jun 2014 00:54:55 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55104 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbaFREyy (ORCPT ); Wed, 18 Jun 2014 00:54:54 -0400 Message-ID: <53A11B45.4010403@ti.com> Date: Wed, 18 Jun 2014 10:23:25 +0530 From: Keerthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Lee Jones CC: Keerthy , , , , , Subject: Re: [PATCH 8/9] regulator: palmas: add driver data and modularize the probe References: <1401272423-25761-1-git-send-email-j-keerthy@ti.com> <1401272423-25761-9-git-send-email-j-keerthy@ti.com> <20140617164502.GS29841@lee--X1> In-Reply-To: <20140617164502.GS29841@lee--X1> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 17 June 2014 10:15 PM, Lee Jones wrote: >> add driver data and modularize the probe. >> >> Signed-off-by: Keerthy >> --- >> drivers/mfd/palmas.c | 42 +-- >> drivers/regulator/palmas-regulator.c | 656 ++++++++++++++++++++-------------- >> 2 files changed, 395 insertions(+), 303 deletions(-) >> >> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c > [...] > >> @@ -370,6 +334,8 @@ int palmas_ext_control_req_config(struct palmas *palmas, >> int bit_pos; >> int ret; >> >> + struct palmas_pmic_driver_data *pmic_ddata = palmas->pmic_ddata; >> + > Nit: I'd prefer the declarations to be grouped together, normally with > the struct defines above the ints etc. Ok. I will change this. > > [...] >