Re: [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info structure definition to the header file

[Keerthy <a0393675@ti.com>]

On Tuesday 17 June 2014 10:03 PM, Lee Jones wrote:
> On Wed, 28 May 2014, Keerthy wrote:
>
>> shift the palmas_sleep_requestor_info structure definition to the header file.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   drivers/mfd/palmas.c       |   10 ----------
>>   include/linux/mfd/palmas.h |   10 ++++++++++
>>   2 files changed, 10 insertions(+), 10 deletions(-)
> Acked-by: Lee Jones <lee.jones@linaro.org>

Thanks.

>
>> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
>> index 485d755..f1f31d5 100644
>> --- a/drivers/mfd/palmas.c
>> +++ b/drivers/mfd/palmas.c
>> @@ -25,16 +25,6 @@
>>   #include <linux/mfd/palmas.h>
>>   #include <linux/of_device.h>
>>   
>> -#define PALMAS_EXT_REQ (PALMAS_EXT_CONTROL_ENABLE1 |	\
>> -			PALMAS_EXT_CONTROL_ENABLE2 |	\
>> -			PALMAS_EXT_CONTROL_NSLEEP)
>> -
>> -struct palmas_sleep_requestor_info {
>> -	int id;
>> -	int reg_offset;
>> -	int bit_pos;
>> -};
>> -
>>   #define EXTERNAL_REQUESTOR(_id, _offset, _pos)		\
>>   	[PALMAS_EXTERNAL_REQSTR_ID_##_id] = {		\
>>   		.id = PALMAS_EXTERNAL_REQSTR_ID_##_id,	\
>> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
>> index 150a6314..8d68452 100644
>> --- a/include/linux/mfd/palmas.h
>> +++ b/include/linux/mfd/palmas.h
>> @@ -88,6 +88,16 @@ struct palmas {
>>   	u8 pwm_muxed;
>>   };
>>   
>> +#define PALMAS_EXT_REQ (PALMAS_EXT_CONTROL_ENABLE1 |	\
>> +			PALMAS_EXT_CONTROL_ENABLE2 |	\
>> +			PALMAS_EXT_CONTROL_NSLEEP)
>> +
>> +struct palmas_sleep_requestor_info {
>> +	int id;
>> +	int reg_offset;
>> +	int bit_pos;
>> +};
>> +
>>   struct regs_info {
>>   	char	*name;
>>   	char	*sname;