[PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment in probe

[PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment in probe

[Felipe Balbi]

From: Keerthy <j-keerthy@ti.com>

Add the missing of_node assignment in probe.

Cc: <stable@vger.kernel.org> # v3.15
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/regulator/tps65218-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index 69b4b77..edbc46e 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -240,6 +240,7 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
 	config.init_data = init_data;
 	config.driver_data = tps;
 	config.regmap = tps->regmap;
+	config.of_node = pdev->dev.of_node;
 
 	rdev = devm_regulator_register(&pdev->dev, &regulators[id], &config);
 	if (IS_ERR(rdev)) {
-- 
2.0.0.rc1

[PATCH 2/2] regulators: TPS65218: Correct the the config register for LDO1

[Felipe Balbi]

From: Keerthy <j-keerthy@ti.com>

Correct the the config register for LDO1.

Cc: <stable@vger.kernel.org> # v3.15
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/regulator/tps65218-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index edbc46e..9effe48 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -209,7 +209,7 @@ static const struct regulator_desc regulators[] = {
 			   1, -1, -1, TPS65218_REG_ENABLE1,
 			   TPS65218_ENABLE1_DC6_EN, NULL, NULL, 0, 0),
 	TPS65218_REGULATOR("LDO1", TPS65218_LDO_1, tps65218_ldo1_dcdc34_ops, 64,
-			   TPS65218_REG_CONTROL_DCDC4,
+			   TPS65218_REG_CONTROL_LDO1,
 			   TPS65218_CONTROL_LDO1_MASK, TPS65218_REG_ENABLE2,
 			   TPS65218_ENABLE2_LDO1_EN, NULL, ldo1_dcdc3_ranges,
 			   2, 0),
-- 
2.0.0.rc1

Re: [PATCH 2/2] regulators: TPS65218: Correct the the config register for LDO1

[Nishanth Menon]

nit pick:
s/regulators: TPS65218:/regulators: tps65218:/

On 06/18/2014 10:17 AM, Felipe Balbi wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> Correct the the config register for LDO1.
> 
> Cc: <stable@vger.kernel.org> # v3.15
Fixes: 90e7d5262796 (regulator: tps65218: Add Regulator driver for
TPS65218 PMIC)
?

> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/regulator/tps65218-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index edbc46e..9effe48 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -209,7 +209,7 @@ static const struct regulator_desc regulators[] = {
>  			   1, -1, -1, TPS65218_REG_ENABLE1,
>  			   TPS65218_ENABLE1_DC6_EN, NULL, NULL, 0, 0),
>  	TPS65218_REGULATOR("LDO1", TPS65218_LDO_1, tps65218_ldo1_dcdc34_ops, 64,
> -			   TPS65218_REG_CONTROL_DCDC4,
> +			   TPS65218_REG_CONTROL_LDO1,
>  			   TPS65218_CONTROL_LDO1_MASK, TPS65218_REG_ENABLE2,
>  			   TPS65218_ENABLE2_LDO1_EN, NULL, ldo1_dcdc3_ranges,
>  			   2, 0),
> 
otherwise,
Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

Re: [PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment in probe

[Nishanth Menon]

nit pick:
s/regulators: TPS65218:/regulators: tps65218:/

On 06/18/2014 10:17 AM, Felipe Balbi wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> Add the missing of_node assignment in probe.
Hmm... I think an explanation of the type below might be nice:

config.of_node is used to populate the regulator_dev->dev.of_node as
part of registration. this is used for consumer supply match to the
right regulator device such as in regulator_dev_lookup.

not populating config.of_node results in inability to use the
regulator node as a supply in device tree.


> 
> Cc: <stable@vger.kernel.org> # v3.15

Fixes: 90e7d5262796 (regulator: tps65218: Add Regulator driver for
TPS65218 PMIC)

?
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/regulator/tps65218-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index 69b4b77..edbc46e 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -240,6 +240,7 @@ static int tps65218_regulator_probe(struct platform_device *pdev)
>  	config.init_data = init_data;
>  	config.driver_data = tps;
>  	config.regmap = tps->regmap;
> +	config.of_node = pdev->dev.of_node;
>  
>  	rdev = devm_regulator_register(&pdev->dev, &regulators[id], &config);
>  	if (IS_ERR(rdev)) {
> 

otherwise,
Acked-by: Nishanth Menon <nm@ti.com>
-- 
Regards,
Nishanth Menon

Re: [PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment in probe

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

On Wed, Jun 18, 2014 at 10:17:47AM -0500, Felipe Balbi wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> Add the missing of_node assignment in probe.

Applied both, thanks.  Please use subject lines reflecting the style for
the subsystem.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]