Re: [PATCH v2 2/2] arm: dts: add support for AM437x StarterKit

Felipe Balbi
2014-06-18T23:24:01Z

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

Hi,

(side note)

On Wed, Jun 18, 2014 at 06:19:23PM -0500, Felipe Balbi wrote:
> > >>>+ interrupt-controller;
> > >>>+ #interrupt-cells = <2>;
> > >>>+
> > >>>+ dcdc1: regulator-dcdc1 {
> > >>>+ compatible = "ti,tps65218-dcdc1";
> > >>>+ /* VDD_CORE limits min of OPP50 and max of OPP100 */
> > >>>+ regulator-name = "vdd_core";
> > >>>+ regulator-min-microvolt = <912000>;
> > >>>+ regulator-max-microvolt = <1144000>;
> > >>>+ regulator-boot-on;
> > >>>+ regulator-always-on;
> > >>>+ };
> > >>>+
> > >>>+ dcdc2: regulator-dcdc2 {
> > >>>+ compatible = "ti,tps65218-dcdc2";
> > >>>+ /* VDD_MPU limits min of OPP50 and max of OPP_NITRO */
> > >>>+ regulator-name = "vdd_mpu";
> > >>>+ regulator-min-microvolt = <912000>;
> > >>>+ regulator-max-microvolt = <1378000>;
> > >>>+ regulator-boot-on;
> > >>>+ regulator-always-on;
> > >>>+ };
> > >>>+
> > >>>+ dcdc3: regulator-dcdc3 {
> > >>>+ compatible = "ti,tps65218-dcdc3";
> > >>>+ regulator-name = "vdds_ddr";
> > >>no voltage ?
> > >
> > >has no users in kernel. Also, it comes out with default, and correct,
> > >voltage.
> >
> > Device tree is description of hardware, not just who uses what in OS
> > of interest.
>
> then we should start "fixing" every single DTS in the kernel because I'm
> sure even LEDs and keypads are tied to some sort of supply, as is the
> case with this board. No driver will use it though.
>
> Also, I couldn't find anywhere which voltage is dcdc3 outputing and
> there's no shunt anywhere (other than a 0 ohm resistor) to measure
> voltage. So I kinda have my hands tied here.
>
> (goes review schematics)
>
> actually there's 0.05 ohm sense resistor. Hopefully it's easy to access.

1.35v

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]