Re: [PATCH v2 1/2] arm: dts: am4372: let boards enable RTC and Watchdog

Nishanth Menon
2014-06-18T21:43:35Z

On 06/18/2014 02:25 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Jun 18, 2014 at 10:55:35AM -0500, Nishanth Menon wrote:
>> $subject - ARM: dts:
>>
>> On 06/18/2014 10:43 AM, Felipe Balbi wrote:
>>> by providing phandles to rtc and wdt nodes, we can
>>> let boards enable rtc and wdt as necessary.
>>>
>>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>>> ---
>>> arch/arm/boot/dts/am4372.dtsi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>>> index 49fa596..e3830d4 100644
>>> --- a/arch/arm/boot/dts/am4372.dtsi
>>> +++ b/arch/arm/boot/dts/am4372.dtsi
>>> @@ -270,7 +270,7 @@
>>> ti,hwmods = "counter_32k";
>>> };
>>>
>>> - rtc@44e3e000 {
>>> + rtc: rtc@44e3e000 {
>>> compatible = "ti,am4372-rtc","ti,da830-rtc";
>>> reg = <0x44e3e000 0x1000>;
>>> interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH
>>> @@ -279,7 +279,7 @@
>>> status = "disabled";
>>> };
>>>
>>> - wdt@44e35000 {
>>> + wdt: wdt@44e35000 {
>>> compatible = "ti,am4372-wdt","ti,omap3-wdt";
>>> reg = <0x44e35000 0x1000>;
>>> interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
>>>
>> we might want to fix up any other similar nodes in dtsi as well, no?
>>
>> examples:
>> cpu@0
>
> and why would you want boards to mess with the cpu node ?
>
cpu-supply = <&regulator>;

for cpufreq.