From: Pavel Emelyanov <xemul@parallels.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>,
<containers@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Serge Hallyn <serge.hallyn@ubuntu.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"David Howells" <dhowells@redhat.com>,
Richard Weinberger <richard.weinberger@gmail.com>,
Vasiliy Kulikov <segooon@gmail.com>,
"Gotou Yasunori" <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH] ns: introduce getnspid syscall
Date: Wed, 18 Jun 2014 23:10:23 +0400 [thread overview]
Message-ID: <53A1E41F.9010504@parallels.com> (raw)
In-Reply-To: <20140618180237.GA22219@redhat.com>
On 06/18/2014 10:02 PM, Oleg Nesterov wrote:
> On 06/17, Pavel Emelyanov wrote:
>>
>> On 06/17/2014 02:21 PM, Chen Hanxiao wrote:
>>> + case PIDTYPE_PID:
>>> + ret = task_pid_nr_ns(task, ns2);
>>
>> But this is not correct. If task doesn't live in ns2, but ns2
>> just has the ns->level small enough, then the wrong pid value
>> would be reported.
>
> Confused... pid_nr_ns() checks upid->ns == ns and returns zero
> otherwise?
Yes, you're right. I've missed that line of code :(
> Oleg.
>
> .
>
next prev parent reply other threads:[~2014-06-18 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 10:21 [PATCH] ns: introduce getnspid syscall Chen Hanxiao
2014-06-17 12:13 ` Pavel Emelyanov
2014-06-18 8:28 ` chenhanxiao
2014-06-18 18:02 ` Oleg Nesterov
2014-06-18 19:10 ` Pavel Emelyanov [this message]
2014-06-17 18:27 ` Michael Kerrisk
2014-06-18 8:29 ` chenhanxiao
2014-06-18 1:31 ` Eric W. Biederman
2014-06-18 10:03 ` chenhanxiao
2014-06-18 17:58 ` Oleg Nesterov
2014-06-20 9:14 ` chenhanxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1E41F.9010504@parallels.com \
--to=xemul@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=berrange@redhat.com \
--cc=chenhanxiao@cn.fujitsu.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=segooon@gmail.com \
--cc=serge.hallyn@ubuntu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox