public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <openosd@gmail.com>
To: Michal Marek <mmarek@suse.cz>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: kbuild: support of new KBUILD_FULL_PATH
Date: Thu, 19 Jun 2014 13:12:57 +0300	[thread overview]
Message-ID: <53A2B7A9.7080605@gmail.com> (raw)
In-Reply-To: <53A1D3A1.70202@gmail.com>


The commit:

	commit 9da0763bdd82572be243fcf5161734f11568960f
	Author: Michal Marek <mmarek@suse.cz>
	Date:   Fri Apr 25 23:25:18 2014 +0200

	kbuild: Use relative path when building in a subdir of the source tree

	When doing make O=<subdir>, use '..' to refer to the source tree. This
	allows for more readable compiler messages, and, more importantly, it
	sets the VPATH to '..', so filenames in WARN_ON() etc. will be shorter.

	Acked-by: Sam Ravnborg <sam@ravnborg.org>
	Signed-off-by: Michal Marek <mmarek@suse.cz>

Broke IDEs and other tools which analyze the make output.
Introduce a new KBUILD_FULL_PATH switch to Makefile that will revert
to the old output if KBUILD_FULL_PATH=1 is specified.
The default is KBUILD_FULL_PATH=0

Is there a document I need to edit for this new parameter?

Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
---
 Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 97b2861..778732a 100644
--- a/Makefile
+++ b/Makefile
@@ -149,11 +149,17 @@ else
 _all: modules
 endif
 
+# put KBUILD_FULL_PATH=1 if relative path to sources breaks your system
+ifneq ($(KBUILD_FULL_PATH), 1)
+	KBUILD_FULL_PATH=""
+endif
+
 ifeq ($(KBUILD_SRC),)
         # building in the source tree
         srctree := .
 else
-        ifeq ($(KBUILD_SRC)/,$(dir $(CURDIR)))
+        # if KBUILD_FULL_PATH is not empty then condition will fail
+        ifeq ($(KBUILD_FULL_PATH)$(KBUILD_SRC)/,$(dir $(CURDIR)))
                 # building in a subdirectory of the source tree
                 srctree := ..
         else
-- 
1.9.3



  parent reply	other threads:[~2014-06-19 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18 18:00 9da0763 "kbuild: Use relative path ..." Broke my IDE Boaz Harrosh
2014-06-18 19:56 ` Alexei Starovoitov
2014-06-19 10:12 ` Boaz Harrosh [this message]
2014-06-19 10:41   ` kbuild: support of new KBUILD_FULL_PATH Michal Marek
2014-06-19 12:01     ` Boaz Harrosh
2014-06-19 13:14       ` Michal Marek
2014-06-19 14:52         ` [PATCH] " Boaz Harrosh
2014-06-19 14:59           ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A2B7A9.7080605@gmail.com \
    --to=openosd@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox