From: Tero Kristo <t-kristo@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Mike Turquette <mturquette@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>, J Keerthy <j-keerthy@ti.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] CLK: TI: APLL: not allocating enough data
Date: Thu, 19 Jun 2014 14:25:12 +0300 [thread overview]
Message-ID: <53A2C898.4090607@ti.com> (raw)
In-Reply-To: <20140616093233.GA9446@mwanda>
On 06/16/2014 12:32 PM, Dan Carpenter wrote:
> There is a cut and paste bug here which will lead to memory corruption
> because we don't allocate enough data.
>
> Fixes: 4d008589e271 ('CLK: TI: APLL: add support for omap2 aplls')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, queued for 3.16-rc fixes.
-Tero
>
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 5428c9c..18dbaf12 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -338,7 +338,7 @@ static void __init of_omap2_apll_setup(struct device_node *node)
> const char *parent_name;
> u32 val;
>
> - ad = kzalloc(sizeof(*clk_hw), GFP_KERNEL);
> + ad = kzalloc(sizeof(*ad), GFP_KERNEL);
> clk_hw = kzalloc(sizeof(*clk_hw), GFP_KERNEL);
> init = kzalloc(sizeof(*init), GFP_KERNEL);
>
>
prev parent reply other threads:[~2014-06-19 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 9:32 [patch] CLK: TI: APLL: not allocating enough data Dan Carpenter
2014-06-19 11:25 ` Tero Kristo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2C898.4090607@ti.com \
--to=t-kristo@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=j-keerthy@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox