* Re: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x
2014-06-19 14:07 [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x Gregory CLEMENT
@ 2014-06-19 14:54 ` Rob Herring
2014-06-19 16:24 ` Gregory CLEMENT
2014-06-19 16:32 ` Sergei Shtylyov
2014-06-19 16:34 ` Sergei Shtylyov
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2014-06-19 14:54 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Thomas Petazzoni, Ezequiel Garcia,
linux-arm-kernel@lists.infradead.org, Grant Likely, Rob Herring,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
On Thu, Jun 19, 2014 at 9:07 AM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> For the Armada 380 and Armada 385 SoCs, the common bindings for those
> 2 SoCs, was forgotten. This patch add the documentation for the
> marvell,aramda38x property.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
>
> This fix should be merged in 3.16. For 3.15 I am not sure as it is not
> a regression.
>
> Thanks,
> Gregory
>
> Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt
> index 11f2330a6554..b68bcb80d2de 100644
> --- a/Documentation/devicetree/bindings/arm/armada-38x.txt
> +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt
> @@ -6,5 +6,9 @@ following property:
>
> Required root node property:
>
> +compatible: must contain "marvell,armada38x"
> +
> +Required root node property:
> +
> - compatible: must contain either "marvell,armada380" or
> "marvell,armada385" depending on the variant of the SoC being used.
This looks a bit strange. How about something like this:
- compatible: must contain either "marvell,armada380" or
"marvell,armada385" depending on the variant of the SoC being
used and contain "marvell,armada38x".
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x
2014-06-19 14:54 ` Rob Herring
@ 2014-06-19 16:24 ` Gregory CLEMENT
0 siblings, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2014-06-19 16:24 UTC (permalink / raw)
To: Rob Herring
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
Thomas Petazzoni, Ezequiel Garcia,
linux-arm-kernel@lists.infradead.org, Grant Likely, Rob Herring,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Rob,
On 19/06/2014 16:54, Rob Herring wrote:
> On Thu, Jun 19, 2014 at 9:07 AM, Gregory CLEMENT
> <gregory.clement@free-electrons.com> wrote:
>> For the Armada 380 and Armada 385 SoCs, the common bindings for those
>> 2 SoCs, was forgotten. This patch add the documentation for the
>> marvell,aramda38x property.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> Hi,
>>
>> This fix should be merged in 3.16. For 3.15 I am not sure as it is not
>> a regression.
>>
>> Thanks,
>> Gregory
>>
>> Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt
>> index 11f2330a6554..b68bcb80d2de 100644
>> --- a/Documentation/devicetree/bindings/arm/armada-38x.txt
>> +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt
>> @@ -6,5 +6,9 @@ following property:
>>
>> Required root node property:
>>
>> +compatible: must contain "marvell,armada38x"
>> +
>> +Required root node property:
>> +
>> - compatible: must contain either "marvell,armada380" or
>> "marvell,armada385" depending on the variant of the SoC being used.
>
> This looks a bit strange. How about something like this:
>
> - compatible: must contain either "marvell,armada380" or
> "marvell,armada385" depending on the variant of the SoC being
> used and contain "marvell,armada38x".
Indeed it will be more clear written in this way.
Thanks,
Gregory
>
> Rob
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x
2014-06-19 14:07 [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x Gregory CLEMENT
2014-06-19 14:54 ` Rob Herring
@ 2014-06-19 16:32 ` Sergei Shtylyov
2014-06-19 16:34 ` Sergei Shtylyov
2 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2014-06-19 16:32 UTC (permalink / raw)
To: Gregory CLEMENT, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth
Cc: Thomas Petazzoni, devicetree, linux-kernel, Rob Herring,
Ezequiel Garcia, Grant Likely, linux-arm-kernel
On 06/19/2014 06:07 PM, Gregory CLEMENT wrote:
> For the Armada 380 and Armada 385 SoCs, the common bindings for those
> 2 SoCs, was forgotten. This patch add the documentation for the
> marvell,aramda38x property.
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
> This fix should be merged in 3.16. For 3.15 I am not sure as it is not
> a regression.
> Thanks,
> Gregory
> Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt
> index 11f2330a6554..b68bcb80d2de 100644
> --- a/Documentation/devicetree/bindings/arm/armada-38x.txt
> +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt
> @@ -6,5 +6,9 @@ following property:
>
> Required root node property:
>
> +compatible: must contain "marvell,armada38x"
> +
> +Required root node property:
Duplicate statement with the above?
> +
> - compatible: must contain either "marvell,armada380" or
> "marvell,armada385" depending on the variant of the SoC being used.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x
2014-06-19 14:07 [PATCH] ARM: mvebu: Fix missing binding documentation for Armada 38x Gregory CLEMENT
2014-06-19 14:54 ` Rob Herring
2014-06-19 16:32 ` Sergei Shtylyov
@ 2014-06-19 16:34 ` Sergei Shtylyov
2 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2014-06-19 16:34 UTC (permalink / raw)
To: Gregory CLEMENT, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth
Cc: Thomas Petazzoni, devicetree, linux-kernel, Rob Herring,
Ezequiel Garcia, Grant Likely, linux-arm-kernel
On 06/19/2014 06:07 PM, Gregory CLEMENT wrote:
> For the Armada 380 and Armada 385 SoCs, the common bindings for those
> 2 SoCs, was forgotten. This patch add the documentation for the
> marvell,aramda38x property.
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
> This fix should be merged in 3.16. For 3.15 I am not sure as it is not
> a regression.
> Thanks,
> Gregory
> Documentation/devicetree/bindings/arm/armada-38x.txt | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/Documentation/devicetree/bindings/arm/armada-38x.txt b/Documentation/devicetree/bindings/arm/armada-38x.txt
> index 11f2330a6554..b68bcb80d2de 100644
> --- a/Documentation/devicetree/bindings/arm/armada-38x.txt
> +++ b/Documentation/devicetree/bindings/arm/armada-38x.txt
> @@ -6,5 +6,9 @@ following property:
>
> Required root node property:
>
> +compatible: must contain "marvell,armada38x"
Oh, and the wildcards are a no-no in the "compatible" prop.
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread