[PATCH] mips: n32: use compat getsockopt syscall

[PATCH] mips: n32: use compat getsockopt syscall

[Sorin Dumitru]

Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
---
 arch/mips/kernel/scall64-n32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index c1dbcda..e543861 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -162,7 +162,7 @@ EXPORT(sysn32_call_table)
 	PTR	sys_getpeername
 	PTR	sys_socketpair
 	PTR	compat_sys_setsockopt
-	PTR	sys_getsockopt
+	PTR	compat_sys_getsockopt
 	PTR	__sys_clone			/* 6055 */
 	PTR	__sys_fork
 	PTR	compat_sys_execve
-- 
2.0.0

Re: [PATCH] mips: n32: use compat getsockopt syscall

[James Hogan]

On 20/06/14 08:53, Sorin Dumitru wrote:
> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>

A little more commit message wouldn't hurt. Did it break a particular
program?

It's consistent with compat_sys_socketcall(), include/uapi/asm/unistd.h,
and commit 515c7af85ed9 (which does same thing for x32) though so it
looks good to me.

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> ---
>  arch/mips/kernel/scall64-n32.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index c1dbcda..e543861 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -162,7 +162,7 @@ EXPORT(sysn32_call_table)
>  	PTR	sys_getpeername
>  	PTR	sys_socketpair
>  	PTR	compat_sys_setsockopt
> -	PTR	sys_getsockopt
> +	PTR	compat_sys_getsockopt
>  	PTR	__sys_clone			/* 6055 */
>  	PTR	__sys_fork
>  	PTR	compat_sys_execve
> 

Re: [PATCH] mips: n32: use compat getsockopt syscall

[Sorin Dumitru]

On 06/20/14 12:54, James Hogan wrote:
> On 20/06/14 08:53, Sorin Dumitru wrote:
>> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
>
> A little more commit message wouldn't hurt. Did it break a particular
> program?

Yes, it was found by an internal program trying to get IP_PKTOPTIONS on 
a cavium octeon board.

Should I resubmit stating what was broken in the commit message?

Thanks,
Sorin

Re: [PATCH] mips: n32: use compat getsockopt syscall

[James Hogan]

On 20/06/14 11:40, Sorin Dumitru wrote:
> On 06/20/14 12:54, James Hogan wrote:
>> On 20/06/14 08:53, Sorin Dumitru wrote:
>>> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
>>
>> A little more commit message wouldn't hurt. Did it break a particular
>> program?
> 
> Yes, it was found by an internal program trying to get IP_PKTOPTIONS on
> a cavium octeon board.
> 
> Should I resubmit stating what was broken in the commit message?

Yeh, if you don't mind. I think it's useful to know exactly why a change
was made and what it fixes when later digging through the git history
(e.g. commit 515c7af85ed9 is a great example of that).

Thanks
James