From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, mattieu.souchaud@free.fr
Subject: Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path
Date: Fri, 20 Jun 2014 16:16:50 -0400 [thread overview]
Message-ID: <53A496B2.2090701@oracle.com> (raw)
In-Reply-To: <20140620200358.GK11391@pd.tnic>
On 06/20/2014 04:03 PM, Borislav Petkov wrote:
> On Fri, Jun 20, 2014 at 03:39:34PM -0400, Boris Ostrovsky wrote:
>> What about mce_device_add()?
> What is a mce_device_add()? There's no such function.
>
Sorry, mce_device_create().
We can't call it in the notifier until mcheck_init_device() has been
successfully executed (we need subsys_system_register(&mce_subsys)). I
don't know whether we can call subsys_system_register() in mcheck_init()
-- it is quite early in the boot.
-boris
next prev parent reply other threads:[~2014-06-20 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 14:28 [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path Boris Ostrovsky
2014-06-20 15:23 ` Borislav Petkov
2014-06-20 15:41 ` Boris Ostrovsky
2014-06-20 15:58 ` Borislav Petkov
2014-06-20 16:16 ` Boris Ostrovsky
2014-06-20 17:52 ` Borislav Petkov
2014-06-20 19:39 ` Boris Ostrovsky
2014-06-20 20:03 ` Borislav Petkov
2014-06-20 20:16 ` Boris Ostrovsky [this message]
2014-06-20 20:29 ` Borislav Petkov
2014-06-20 20:43 ` Boris Ostrovsky
2014-06-20 21:11 ` Borislav Petkov
2014-06-21 2:04 ` Boris Ostrovsky
2014-06-21 10:08 ` Borislav Petkov
2014-07-24 23:36 ` [tip:x86/urgent] x86, MCE: Robustify mcheck_init_device tip-bot for Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2014-06-22 17:25 [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path Boris Ostrovsky
2014-06-24 10:25 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A496B2.2090701@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattieu.souchaud@free.fr \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).