[PATCH 01/01] Drivers: Fixes coding style warning

[PATCH 01/01] Drivers: Fixes coding style warning

[Ramesh Basukala]

*

From: Ramesh Basukala <basukalaramesh@gmail.com>


Attached is a patch which fixes coding style warning message while 
running checkpatch script.


This patch is currently against a linux 3.15.0-rc15-next kernel. I am 
submitting this patch as a part of Eudyptula Challenge task.


Signed-off-by: Ramesh Basukala <basukalaramesh@gmail.com>
*---
Signed-off-by: Ramesh Basukala <basukalaramesh@gmail.com>
--- xlr_net.c.original 2014-06-20 15:32:10.069732488 -0400
+++ xlr_net.c 2014-06-20 15:35:06.841105038 -0400
@@ -1105,6 +1105,7 @@ err_gmac:
static int xlr_net_remove(struct platform_device *pdev)
{
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv->ndev);
mdiobus_unregister(priv->mii_bus);
mdiobus_free(priv->mii_bus);
**

Re: [PATCH 01/01] Drivers: Fixes coding style warning

[Greg KH]

On Fri, Jun 20, 2014 at 04:25:22PM -0400, Ramesh Basukala wrote:
> *

What is that for?

> 
> From: Ramesh Basukala <basukalaramesh@gmail.com>
> 
> 
> Attached is a patch which fixes coding style warning message while running
> checkpatch script.
> 
> 
> This patch is currently against a linux 3.15.0-rc15-next kernel. I am

There is no 3.15-rc15 kernel release :(

> submitting this patch as a part of Eudyptula Challenge task.

Not needed here.

> 
> 
> Signed-off-by: Ramesh Basukala <basukalaramesh@gmail.com>
> *---
> Signed-off-by: Ramesh Basukala <basukalaramesh@gmail.com>
> --- xlr_net.c.original 2014-06-20 15:32:10.069732488 -0400
> +++ xlr_net.c 2014-06-20 15:35:06.841105038 -0400
> @@ -1105,6 +1105,7 @@ err_gmac:
> static int xlr_net_remove(struct platform_device *pdev)
> {
> struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +
> unregister_netdev(priv->ndev);
> mdiobus_unregister(priv->mii_bus);
> mdiobus_free(priv->mii_bus);
> **


This doesn't apply at all, please always test your patches yourself
before resending them.

Also, be explicit as to what you are fixing (what part of the kernel),
and use the scripts/get_maintainers.pl tool to send the patches to the
correct people and mailing list.

Care to try again?

greg k-h

[PATCH 01/01] Drivers: Fixes coding style warning

[Ramesh Basukala]

From: Ramesh Basukala <basukalaramesh@gmail.com>

Attached is a patch which fixes coding style warning message while 
running checkpatch script.
This patch is currently against a linux 3.15.0-rc15-next kernel. I am 
submitting this patch as a part of Eudyptula Challenge task.

Signed-off-by: Ramesh Basukala <basukalaramesh@gmail.com>
--- xlr_net.c.original 2014-06-20 15:32:10.069732488 -0400
+++ xlr_net.c 2014-06-20 15:35:06.841105038 -0400
@@ -1105,6 +1105,7 @@ err_gmac:
static int xlr_net_remove(struct platform_device *pdev)
{
struct xlr_net_priv *priv = platform_get_drvdata(pdev);
+
unregister_netdev(priv->ndev);
mdiobus_unregister(priv->mii_bus);
mdiobus_free(priv->mii_bus);