From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Emil Goode <emilgoode@gmail.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772_unbind
Date: Sat, 21 Jun 2014 04:09:04 +0400 [thread overview]
Message-ID: <53A4CD20.2000505@cogentembedded.com> (raw)
In-Reply-To: <1403296852-6376-1-git-send-email-fabf@skynet.be>
Hello.
On 06/21/2014 12:40 AM, Fabian Frederick wrote:
> inline this one line function used in driver_info structure
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Emil Goode <emilgoode@gmail.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/net/usb/asix_devices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 8a7582b..a41926a 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -497,7 +497,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
> return 0;
> }
>
> -static void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
> +static inline void ax88772_unbind(struct usbnet *dev, struct usb_interface *intf)
> {
> kfree(dev->driver_priv);
> }
gcc is perfectly capable of figuring that out. No need to use *inline*
outside the *.h files.
WBR, Sergei
next prev parent reply other threads:[~2014-06-21 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 20:40 [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772_unbind Fabian Frederick
2014-06-21 0:09 ` Sergei Shtylyov [this message]
2014-06-23 6:58 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A4CD20.2000505@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=emilgoode@gmail.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox