From: Chen Gang <gang.chen.5i5j@gmail.com>
To: mingo@redhat.com, rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] include/trace/syscall.h: Use HAVE_SYSCALL_TRACEPOINTS instead of TRACEPOINTS
Date: Sat, 21 Jun 2014 10:32:37 +0800 [thread overview]
Message-ID: <53A4EEC5.7090801@gmail.com> (raw)
At present, most architectures can support TRACEPOINTS, but about 10/29
architectures support HAVE_SYSCALL_TRACEPOINTS.
TIF_SYSCALL_TRACEPOINT depends on HAVE_SYSCALL_TRACEPOINTS, not all
architectures which support TRACEPOINTS also must support
TIF_SYSCALL_TRACEPOINT.
So at present, need use HAVE_SYSCALL_TRACEPOINTS instead of TRACEPOINTS,
or can not pass compiling. The related error (allmodconfig under score):
CC init/main.o
In file included from include/asm-generic/preempt.h:4:0,
from arch/score/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:18,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from init/main.c:15:
include/trace/syscall.h: In function 'syscall_tracepoint_update':
include/trace/syscall.h:39:23: error: 'TIF_SYSCALL_TRACEPOINT' undeclared (first use in this function)
if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
^
include/linux/thread_info.h:103:45: note: in definition of macro 'test_thread_flag'
test_ti_thread_flag(current_thread_info(), flag)
^
include/trace/syscall.h:39:23: note: each undeclared identifier is reported only once for each function it appears in
if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
^
include/linux/thread_info.h:103:45: note: in definition of macro 'test_thread_flag'
test_ti_thread_flag(current_thread_info(), flag)
^
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
include/trace/syscall.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/syscall.h b/include/trace/syscall.h
index 291c282..a709cbd 100644
--- a/include/trace/syscall.h
+++ b/include/trace/syscall.h
@@ -33,7 +33,7 @@ struct syscall_metadata {
struct ftrace_event_call *exit_event;
};
-#ifdef CONFIG_TRACEPOINTS
+#ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS
static inline void syscall_tracepoint_update(struct task_struct *p)
{
if (test_thread_flag(TIF_SYSCALL_TRACEPOINT))
--
1.9.2.459.g68773ac
next reply other threads:[~2014-06-21 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 2:32 Chen Gang [this message]
2014-06-21 3:43 ` [PATCH] include/trace/syscall.h: Use HAVE_SYSCALL_TRACEPOINTS instead of TRACEPOINTS Steven Rostedt
2014-06-21 12:19 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A4EEC5.7090801@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox