* [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value
@ 2014-06-11 19:54 Fabian Frederick
2014-06-23 11:35 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-11 19:54 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen
unsigned value is never < 0
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/video/fbdev/sis/sis_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 22ad028..3f12a2d 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -1572,10 +1572,6 @@ sisfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
/* Adapt RGB settings */
sisfb_bpp_to_var(ivideo, var);
- /* Sanity check for offsets */
- if(var->xoffset < 0) var->xoffset = 0;
- if(var->yoffset < 0) var->yoffset = 0;
-
if(var->xres > var->xres_virtual)
var->xres_virtual = var->xres;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value
2014-06-11 19:54 [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value Fabian Frederick
@ 2014-06-23 11:35 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-06-23 11:35 UTC (permalink / raw)
To: Fabian Frederick, linux-kernel; +Cc: Jean-Christophe Plagniol-Villard
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On 11/06/14 22:54, Fabian Frederick wrote:
> unsigned value is never < 0
>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/video/fbdev/sis/sis_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 22ad028..3f12a2d 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -1572,10 +1572,6 @@ sisfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
> /* Adapt RGB settings */
> sisfb_bpp_to_var(ivideo, var);
>
> - /* Sanity check for offsets */
> - if(var->xoffset < 0) var->xoffset = 0;
> - if(var->yoffset < 0) var->yoffset = 0;
> -
> if(var->xres > var->xres_virtual)
> var->xres_virtual = var->xres;
>
>
Thanks, queued for 3.17.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-23 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 19:54 [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value Fabian Frederick
2014-06-23 11:35 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox