Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq_get fails

[Guenter Roeck <linux@roeck-us.net>]

On 06/23/2014 08:48 AM, Rob Herring wrote:
> On Tue, Jun 17, 2014 at 5:51 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq)
>> and ad69674 (of/irq: do irq resolution in platform_get_irq_byname)
>> change the semantics of platform_get_irq and platform_get_irq_byname
>> to always rely on devicetree information if devicetree is enabled
>> and if a devicetree node is attached to the device. The functions
>> now return an error if the devicetree data does not include interrupt
>> information, even if the information is available as platform resource
>> data.
>>
>> This causes mfd client drivers to fail if the interrupt number is
>> passed via platform resources. Therefore, if of_irq_get fails, try
>> platform_get_resource as method of last resort. This restores the
>> original functionality for drivers depending on platform resources
>> to get irq information.
>>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Grant Likely <grant.likely@linaro.org>
>> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> Greg should take this for 3.16.
>

Wound be great. In the meantime, I asked for the da9055 code to be re-tested,
since I suspect that it may be affected. There may be others, but I don't have
the time to track it all down.

Thanks,
Guenter