From: Sherman Yin <syin@broadcom.com>
To: Sachin Kamat <sachin.kamat@samsung.com>, <linux-kernel@vger.kernel.org>
Cc: <linus.walleij@linaro.org>, <spk.linux@gmail.com>
Subject: Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
Date: Mon, 23 Jun 2014 11:05:23 -0700 [thread overview]
Message-ID: <53A86C63.7020103@broadcom.com> (raw)
In-Reply-To: <1403523498-3035-1-git-send-email-sachin.kamat@samsung.com>
Hi Sachin,
Looks good, thanks. How did you come across the need for this change?
Regards,
Sherman
On 14-06-23 04:38 AM, Sachin Kamat wrote:
> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> drivers/pinctrl/pinctrl-bcm281xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
> index 3bed792b2c03..c5ca9e633fff 100644
> --- a/drivers/pinctrl/pinctrl-bcm281xx.c
> +++ b/drivers/pinctrl/pinctrl-bcm281xx.c
> @@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
> .owner = THIS_MODULE,
> };
>
> -int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> +static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> {
> struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
> struct resource *res;
>
next prev parent reply other threads:[~2014-06-23 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 11:38 [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe Sachin Kamat
2014-06-23 18:05 ` Sherman Yin [this message]
2014-06-24 3:44 ` Sachin Kamat
2014-07-07 15:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A86C63.7020103@broadcom.com \
--to=syin@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox