* [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
@ 2014-06-23 11:38 Sachin Kamat
2014-06-23 18:05 ` Sherman Yin
2014-07-07 15:28 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2014-06-23 11:38 UTC (permalink / raw)
To: linux-kernel; +Cc: syin, linus.walleij, spk.linux
bcm281xx_pinctrl_probe is local to this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
drivers/pinctrl/pinctrl-bcm281xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
};
-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
{
struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
struct resource *res;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
2014-06-23 11:38 [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe Sachin Kamat
@ 2014-06-23 18:05 ` Sherman Yin
2014-06-24 3:44 ` Sachin Kamat
2014-07-07 15:28 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Sherman Yin @ 2014-06-23 18:05 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel; +Cc: linus.walleij, spk.linux
Hi Sachin,
Looks good, thanks. How did you come across the need for this change?
Regards,
Sherman
On 14-06-23 04:38 AM, Sachin Kamat wrote:
> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> drivers/pinctrl/pinctrl-bcm281xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
> index 3bed792b2c03..c5ca9e633fff 100644
> --- a/drivers/pinctrl/pinctrl-bcm281xx.c
> +++ b/drivers/pinctrl/pinctrl-bcm281xx.c
> @@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
> .owner = THIS_MODULE,
> };
>
> -int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> +static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> {
> struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
> struct resource *res;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
2014-06-23 18:05 ` Sherman Yin
@ 2014-06-24 3:44 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2014-06-24 3:44 UTC (permalink / raw)
To: Sherman Yin; +Cc: open list, Linus Walleij
Hi Sherman,
On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin <syin@broadcom.com> wrote:
> Hi Sachin,
>
> Looks good, thanks. How did you come across the need for this change?
Thanks for the review. Sparse threw up a warning while doing a regular build.
Regards,
Sachin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe
2014-06-23 11:38 [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe Sachin Kamat
2014-06-23 18:05 ` Sherman Yin
@ 2014-07-07 15:28 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-07-07 15:28 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel@vger.kernel.org, Sherman Yin, spk.linux
On Mon, Jun 23, 2014 at 1:38 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-07 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 11:38 [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe Sachin Kamat
2014-06-23 18:05 ` Sherman Yin
2014-06-24 3:44 ` Sachin Kamat
2014-07-07 15:28 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox