From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922AbaFWW2f (ORCPT ); Mon, 23 Jun 2014 18:28:35 -0400 Received: from mail-oa0-f52.google.com ([209.85.219.52]:64024 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbaFWW2d (ORCPT ); Mon, 23 Jun 2014 18:28:33 -0400 Message-ID: <53A8AA0E.8070705@ti.com> Date: Mon, 23 Jun 2014 17:28:30 -0500 From: Nishanth Menon Reply-To: nm@ti.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Stephen Warren , Liam Girdwood , Mark Brown CC: linux-kernel@vger.kernel.org, Stephen Warren , Alex Courbot , Keerthy , linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] regulator: palmas: fix typo in enable_reg calculation References: <1403556805-22824-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1403556805-22824-1-git-send-email-swarren@wwwdotorg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/23/2014 03:53 PM, Stephen Warren wrote: > From: Stephen Warren > > When setting up .enable_reg for an SMPS regulator, presumably we should > call PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE, ...) rather than using > LDO_BASE. This change makes the LCD panel and HDMI work again on the > NVIDIA Dalmore board anyway. > > Cc: Alex Courbot > Cc: Keerthy > Cc: Nishanth Menon > Cc: linux-omap@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Fixes: 318dbb02b50c ("regulator: palmas: Fix SMPS enable/disable/is_enabled") > Fixes: dbabd624d4eec50b6 ("regulator: palmas: Reemove open coded functions with helper functions") > Signed-off-by: Stephen Warren > --- > drivers/regulator/palmas-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c > index 3c861d5f9245..93b4ad842901 100644 > --- a/drivers/regulator/palmas-regulator.c > +++ b/drivers/regulator/palmas-regulator.c > @@ -970,7 +970,7 @@ static int palmas_regulators_probe(struct platform_device *pdev) > PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; > > pmic->desc[id].enable_reg = > - PALMAS_BASE_TO_REG(PALMAS_LDO_BASE, > + PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE, > palmas_regs_info[id].ctrl_addr); > pmic->desc[id].enable_mask = > PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; > Uggh... my bad.. Thanks for catching this. Acked-by: Nishanth Menon