* [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization
@ 2014-06-24 8:24 Sachin Kamat
2014-06-24 8:38 ` Laxman Dewangan
2014-06-24 15:10 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2014-06-24 8:24 UTC (permalink / raw)
To: linux-kernel; +Cc: ldewangan, broonie, lgirdwood, spk.linux
'name' field was re-initialized and getting overwritten in some
cases possibly due to a typo. Code inspection says the second time
it should be 'sname' instead of 'name'. Replace it.
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
Compile tested only.
---
drivers/regulator/as3722-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index ad9e0c9b7daf..b68f05f38537 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization
2014-06-24 8:24 [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization Sachin Kamat
@ 2014-06-24 8:38 ` Laxman Dewangan
2014-06-24 15:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2014-06-24 8:38 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel@vger.kernel.org
Cc: broonie@kernel.org, lgirdwood@gmail.com, spk.linux@gmail.com
On Tuesday 24 June 2014 01:54 PM, Sachin Kamat wrote:
> 'name' field was re-initialized and getting overwritten in some
> cases possibly due to a typo. Code inspection says the second time
> it should be 'sname' instead of 'name'. Replace it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>
Agree, thanks for finding this.
Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization
2014-06-24 8:24 [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization Sachin Kamat
2014-06-24 8:38 ` Laxman Dewangan
@ 2014-06-24 15:10 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-06-24 15:10 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, ldewangan, lgirdwood, spk.linux
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Tue, Jun 24, 2014 at 01:54:43PM +0530, Sachin Kamat wrote:
> 'name' field was re-initialized and getting overwritten in some
> cases possibly due to a typo. Code inspection says the second time
> it should be 'sname' instead of 'name'. Replace it.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-24 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 8:24 [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization Sachin Kamat
2014-06-24 8:38 ` Laxman Dewangan
2014-06-24 15:10 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox