From: Stephen Warren <swarren@wwwdotorg.org>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gnurou@gmail.com" <gnurou@gmail.com>
Subject: Re: [PATCH 2/2] ARM: tegra: roth: enable input on mmc clock pins
Date: Tue, 24 Jun 2014 09:53:45 -0600 [thread overview]
Message-ID: <53A99F09.1070504@wwwdotorg.org> (raw)
In-Reply-To: <53A91026.7040506@nvidia.com>
On 06/23/2014 11:44 PM, Alexandre Courbot wrote:
> On 06/24/2014 04:01 AM, Stephen Warren wrote:
>> On 06/23/2014 01:32 AM, Alexandre Courbot wrote:
>>> Input had been disabled by mistake on these pins, leading to issues with
>>> SDIO devices like the Wifi module not being probed or random errors
>>> occuring on the SD card.
>>
>> I thought the host controller always drove the clock, so there should be
>> no need for the pin's input path to be enabled. Perhaps it depends on
>> the transfer mode (e.g. UHS)?
>
> That's what I thought too, so I went against what was done downstream
> and disabled input mode. Eventually noticed various issues with MMC
> devices, reverted to the downstream settings and noticed my problems
> were solved by this single change.
Hmm. That's odd. Can you talk to one of the HW engineers behind the
SDHCI controller and get a definitive answer. Thanks.
next prev parent reply other threads:[~2014-06-24 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 7:32 [PATCH 0/2] ARM: tegra: roth: pinmux fixes Alexandre Courbot
2014-06-23 7:32 ` [PATCH 1/2] ARM: tegra: roth: fix unsupported pinmux properties Alexandre Courbot
2014-06-23 7:32 ` [PATCH 2/2] ARM: tegra: roth: enable input on mmc clock pins Alexandre Courbot
2014-06-23 19:01 ` Stephen Warren
2014-06-24 5:44 ` Alexandre Courbot
2014-06-24 15:53 ` Stephen Warren [this message]
2014-06-23 18:46 ` [PATCH 0/2] ARM: tegra: roth: pinmux fixes Stephen Warren
2014-06-24 3:57 ` Alexandre Courbot
2014-06-27 22:08 ` Stephen Warren
2014-06-29 4:27 ` Alexandre Courbot
2014-06-30 15:46 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A99F09.1070504@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox