From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbaFXWeG (ORCPT ); Tue, 24 Jun 2014 18:34:06 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:49053 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbaFXWeE (ORCPT ); Tue, 24 Jun 2014 18:34:04 -0400 Message-ID: <53A9FCDB.6060805@cogentembedded.com> Date: Wed, 25 Jun 2014 02:34:03 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Julius Werner , Vivek Gautam CC: "linux-usb@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Greg Kroah-Hartman , kishon , Mathias Nyman , LKML , "linux-arm-kernel@lists.infradead.org" , Kukjin Kim Subject: Re: [PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs References: <1402056736-12674-1-git-send-email-gautam.vivek@samsung.com> <1402056736-12674-3-git-send-email-gautam.vivek@samsung.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 06/10/2014 12:22 AM, Julius Werner wrote: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index 9ffecd5..453d89e 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1582,6 +1582,9 @@ struct xhci_hcd { >> u32 port_status_u0; >> /* Compliance Mode Timer Triggered every 2 seconds */ >> #define COMP_MODE_RCVRY_MSECS 2000 >> + /* phys for the controller */ >> + struct phy *phy2_gen; >> + struct phy *phy3_gen; >> }; > I don't think adding new variables here and restricting most of this > logic to xhci-plat.c (in the next patch) is the best way to do it. Indeed. > There's no conceptual reason why other host controllers (e.g. xhci-pci > or even EHCI) could not have a similar need to tune their PHY after > reset. PHYs are universal to all host controllers. > There is already a 'phy' member in struct usb_hcd which I think is > mostly unused right now. I think it would be much less > confusing/redundant to reuse that member for this purpose (you could > still set it up from xhci_plat_probe(), and then call it from > hcd_bus_resume() or something like that). That member has type 'struct usb_phy *' while here we have 'struct phy *' -- feel the difference. I have already tried adding 'struct phy *gen_phy' to 'struct usb_hcd', however Greg wasn't eager to pick that up so far. Here's the last posting of my patch: http://marc.info/?l=linux-usb&m=140145917506582 WBR, Sergei