From: Avi Kivity <avi.kivity@gmail.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Andi Kleen <andi@firstfloor.org>
Cc: peterz@infradead.org, gleb@kernel.org, pbonzini@redhat.com,
eranian@google.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/4] kvm: Implement PEBS virtualization
Date: Wed, 25 Jun 2014 10:04:14 +0300 [thread overview]
Message-ID: <53AA746E.1030500@gmail.com> (raw)
In-Reply-To: <20140624164514.GA25220@amt.cnet>
On 06/24/2014 07:45 PM, Marcelo Tosatti wrote:
> On Sun, Jun 22, 2014 at 09:02:25PM +0200, Andi Kleen wrote:
>>> First, it's not sufficient to pin the debug store area, you also
>>> have to pin the guest page tables that are used to map the debug
>>> store. But even if you do that, as soon as the guest fork()s, it
>>> will create a new pgd which the host will be free to swap out. The
>>> processor can then attempt a PEBS store to an unmapped address which
>>> will fail, even though the guest is configured correctly.
>> That's a good point. You're right of course.
>>
>> The only way I can think around it would be to intercept CR3 writes
>> while PEBS is active and always pin all the table pages leading
>> to the PEBS buffer. That's slow, but should be only needed
>> while PEBS is running.
>>
>> -Andi
> Suppose that can be done separately from the pinned spte patchset.
> And it requires accounting into mlock limits as well, as noted.
>
> One set of pagetables per pinned virtual address leading down to the
> last translations is sufficient per-vcpu.
Or 4, and use the CR3 exit filter to prevent vmexits among the last 4
LRU CR3 values.
next prev parent reply other threads:[~2014-06-25 7:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 1:12 Implement PEBS virtualization for Silvermont Andi Kleen
2014-05-30 1:12 ` [PATCH 1/4] perf: Add PEBS virtualization enable " Andi Kleen
2014-05-30 1:12 ` [PATCH 2/4] perf: Allow guest PEBS for KVM owned counters Andi Kleen
2014-05-30 7:31 ` Peter Zijlstra
2014-05-30 16:03 ` Andi Kleen
2014-05-30 16:17 ` Peter Zijlstra
2014-05-30 1:12 ` [PATCH 3/4] perf: Handle guest PEBS events with a fake event Andi Kleen
2014-05-30 7:34 ` Peter Zijlstra
2014-05-30 16:29 ` Andi Kleen
2014-05-30 1:12 ` [PATCH 4/4] kvm: Implement PEBS virtualization Andi Kleen
2014-05-30 8:21 ` Gleb Natapov
2014-05-30 16:24 ` Andi Kleen
2014-06-02 16:45 ` Gleb Natapov
2014-06-02 16:52 ` Andi Kleen
2014-06-02 19:09 ` Marcelo Tosatti
2014-06-02 19:05 ` Eric Northup
2014-06-02 19:57 ` Andi Kleen
2014-06-19 14:39 ` Paolo Bonzini
2014-06-10 18:04 ` Marcelo Tosatti
2014-06-10 19:22 ` Andi Kleen
2014-06-10 21:06 ` Marcelo Tosatti
2014-06-19 14:42 ` Paolo Bonzini
2014-06-19 17:33 ` Andi Kleen
2014-06-19 20:33 ` Paolo Bonzini
2014-06-22 13:57 ` Avi Kivity
2014-06-22 19:02 ` Andi Kleen
2014-06-24 16:45 ` Marcelo Tosatti
2014-06-25 7:04 ` Avi Kivity [this message]
2014-05-30 7:39 ` Implement PEBS virtualization for Silvermont Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AA746E.1030500@gmail.com \
--to=avi.kivity@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).