* [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once
@ 2014-06-25 12:25 Rickard Strandqvist
2014-06-25 12:27 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-25 12:25 UTC (permalink / raw)
To: Gleb Natapov, Paolo Bonzini
Cc: Rickard Strandqvist, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86, kvm, linux-kernel
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/x86/kvm/x86.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index f32a025..0f48eb7 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4730,7 +4730,6 @@ static void emulator_set_segment(struct x86_emulate_ctxt *ctxt, u16 selector,
if (desc->g)
var.limit = (var.limit << 12) | 0xfff;
var.type = desc->type;
- var.present = desc->p;
var.dpl = desc->dpl;
var.db = desc->d;
var.s = desc->s;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once
2014-06-25 12:25 [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once Rickard Strandqvist
@ 2014-06-25 12:27 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-06-25 12:27 UTC (permalink / raw)
To: Rickard Strandqvist, Gleb Natapov
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm,
linux-kernel
Il 25/06/2014 14:25, Rickard Strandqvist ha scritto:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index f32a025..0f48eb7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4730,7 +4730,6 @@ static void emulator_set_segment(struct x86_emulate_ctxt *ctxt, u16 selector,
> if (desc->g)
> var.limit = (var.limit << 12) | 0xfff;
> var.type = desc->type;
> - var.present = desc->p;
> var.dpl = desc->dpl;
> var.db = desc->d;
> var.s = desc->s;
>
Thanks, applying this patch.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-25 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 12:25 [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 12:27 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox