linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	paulus@samba.org, mingo@redhat.com, acme@kernel.org,
	namhyung@kernel.org, artagnon@gmail.com, rusty@rustcorp.com.au,
	bp@suse.de
Subject: Re: [PATCH v4 0/4] perf timechart io mode
Date: Wed, 25 Jun 2014 08:01:17 -0600	[thread overview]
Message-ID: <53AAD62D.3030105@gmail.com> (raw)
In-Reply-To: <20140625112019.GC21788@stfomichev-desktop.yandex.net>

On 6/25/14, 5:20 AM, Stanislav Fomichev wrote:
>>> maybe we dont need to fail in this case.. seems like it should
>>> not be hard to detect, wanr and recover? ;-)
> The easiest way is just to bail out and don't try to be smart, that's
> what I do now.
>
> Another approach would be to just convert all my consistency
> checks to warnings and skip invalid events (and hope it somehow works). I
> think it makes sense when for some reason we have perf.data which
> is not really consistent but we still want to get something out of it.

If the event type does not make sense how can you trust any other field 
-- like event size?

>
>> seems to me it should not be happening at all. It seems like the head caught
>> the tail and was not properly detected.
> So you mean it perf record's fault?
>

In my cases I am running perf-record. At the end of the session it walks 
the events and in too many cases I see the message:

  0x113f80 [0x8]: failed to process type: 68

So, yes I think something is happening during the record such as the 
writer passing the reader and corrupting the buffers.

David

  reply	other threads:[~2014-06-25 14:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 10:29 [PATCH v4 0/4] perf timechart io mode Stanislav Fomichev
2014-06-20 10:29 ` [PATCH 1/4] perf timechart: fix rendering in Firefox Stanislav Fomichev
2014-06-20 10:29 ` [PATCH 2/4] perf timechart: implement IO mode Stanislav Fomichev
2014-06-24  8:34   ` Jiri Olsa
2014-06-24 17:00     ` Stanislav Fomichev
2014-06-24 18:21       ` Jiri Olsa
2014-06-20 10:29 ` [PATCH 3/4] perf timechart: conditionally update start_time on fork Stanislav Fomichev
2014-06-20 10:29 ` [PATCH 4/4] perf timechart: add more options to IO mode Stanislav Fomichev
2014-06-24  6:43 ` [PATCH v4 0/4] perf timechart io mode Namhyung Kim
2014-06-24  8:41 ` Jiri Olsa
2014-06-24  9:10   ` Stanislav Fomichev
2014-06-24 16:57     ` Stanislav Fomichev
2014-06-24 17:01       ` Stanislav Fomichev
2014-06-24 17:38       ` David Ahern
2014-06-24 18:51         ` Jiri Olsa
2014-06-24 19:03           ` David Ahern
2014-06-25 11:20             ` Stanislav Fomichev
2014-06-25 14:01               ` David Ahern [this message]
2014-06-25 14:19                 ` Stanislav Fomichev
2014-06-25 14:38                 ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2014-07-08 16:03 Stanislav Fomichev
2014-07-09  8:23 ` Namhyung Kim
2014-07-09 11:13 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAD62D.3030105@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=artagnon@gmail.com \
    --cc=bp@suse.de \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=rusty@rustcorp.com.au \
    --cc=stfomichev@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).