From: Jack Wang <xjtuwjp@gmail.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
Cc: lindar_liu@usish.com,
"James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once
Date: Thu, 26 Jun 2014 10:09:00 +0200 [thread overview]
Message-ID: <53ABD51C.5050806@gmail.com> (raw)
In-Reply-To: <1403704907-25672-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Thanks Rickard,
>From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
Anand, could you share your opinion?
Regards,
Jack
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in between.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index d70587f..2698227 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -249,7 +249,6 @@ moreData:
> sprintf(pm8001_ha->
> forensic_info.data_buf.direct_data,
> "%08x ", 4);
> - pm8001_ha->forensic_info.data_buf.read_len = 0xFFFFFFFF;
> pm8001_ha->forensic_info.data_buf.direct_len = 0;
> pm8001_ha->forensic_info.data_buf.direct_offset = 0;
> pm8001_ha->forensic_info.data_buf.read_len = 0;
>
next prev parent reply other threads:[~2014-06-26 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:01 [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 15:34 ` Maurizio Lombardi
[not found] ` <CAN7X1Un3-u-Q428-s1dYk5z4P-Bb=jO-N+x1T+PLhH1fDE1MRw@mail.gmail.com>
2014-06-25 16:08 ` Maurizio Lombardi
2014-06-26 8:09 ` Jack Wang [this message]
2014-06-26 8:20 ` Maurizio Lombardi
2014-06-27 9:06 ` Suresh Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ABD51C.5050806@gmail.com \
--to=xjtuwjp@gmail.com \
--cc=AnandKumar.Santhanam@pmcs.com \
--cc=JBottomley@parallels.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox