public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Lennox Wu <lennox.wu@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	David Rientjes <rientjes@google.com>,
	Liqin Chen <liqin.linux@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros which not be used currently
Date: Thu, 26 Jun 2014 20:23:39 +0800	[thread overview]
Message-ID: <53AC10CB.3000007@gmail.com> (raw)

'COUNTER' and other same kind macros are too common to use, and easy to
get conflict with other modules.

At present, they are not used, so it is OK to simply remove them. And the
related warning (allmodconfig with score):

    CC [M]  drivers/md/raid1.o
  In file included from drivers/md/raid1.c:42:0:
  drivers/md/bitmap.h:93:0: warning: "COUNTER" redefined
   #define COUNTER(x) (((bitmap_counter_t) x) & COUNTER_MAX)
   ^
  In file included from ./arch/score/include/asm/ptrace.h:4:0,
                   from include/linux/sched.h:31,
                   from include/linux/blkdev.h:4,
                   from drivers/md/raid1.c:36:
  ./arch/score/include/uapi/asm/ptrace.h:13:0: note: this is the location of the previous definition
   #define COUNTER  38


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/score/include/uapi/asm/ptrace.h | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h
index f59771a..5c5e794 100644
--- a/arch/score/include/uapi/asm/ptrace.h
+++ b/arch/score/include/uapi/asm/ptrace.h
@@ -4,17 +4,6 @@
 #define PTRACE_GETREGS		12
 #define PTRACE_SETREGS		13
 
-#define PC		32
-#define CONDITION	33
-#define ECR		34
-#define EMA		35
-#define CEH		36
-#define CEL		37
-#define COUNTER		38
-#define LDCR		39
-#define STCR		40
-#define PSR		41
-
 #define SINGLESTEP16_INSN	0x7006
 #define SINGLESTEP32_INSN	0x840C8000
 #define BREAKPOINT16_INSN	0x7002		/* work on SPG300 */
-- 
1.9.2.459.g68773ac

             reply	other threads:[~2014-06-26 12:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 12:23 Chen Gang [this message]
2014-06-26 21:56 ` [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros which not be used currently David Rientjes
2014-06-26 23:28   ` Chen Gang
2014-06-27  2:11     ` Lennox Wu
2014-06-27  2:47       ` Chen Gang
2014-06-27  3:25         ` Guenter Roeck
2014-06-27  3:39           ` Chen Gang
2014-07-17  1:49   ` David Rientjes
2014-07-17  2:14     ` Lennox Wu
2014-07-17  2:30       ` Guenter Roeck
2014-07-17  2:52         ` Lennox Wu
2014-07-17  9:08           ` Chen Gang
2014-07-17 21:39           ` David Rientjes
2014-07-22  0:45             ` [patch] score, ptrace: " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AC10CB.3000007@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=lennox.wu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=liqin.linux@gmail.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox