Re: [PATCH] perf script/python: Print array argument as string

Jiri Olsa
2014-06-03T18:55:31Z

On Thu, May 29, 2014 at 01:44:55PM +0900, Namhyung Kim wrote:
> With the Sebastian's change of handling num array argument (of raw
> syscall enter), the script still failed to work like this:
>
> $ perf record -e raw_syscalls:* sleep 1
> $ perf script -g python
> $ perf script -s perf-script.py
> ...
> Traceback (most recent call last):
> File "perf-script.py", line 42, in raw_syscalls__sys_enter
> (id, args),
> TypeError: %u format: a number is required, not list
> Fatal Python error: problem in Python trace event handler
> Aborted (core dumped)
>
> This is because the generated script tries to print the array arg as
> unsigned integer (%u). Since the python seems to convert arguments to
> strings by default, just using %s solved the problem for me.
>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

ack/test anyone? ;-)

thanks,
jirka

> ---
> tools/perf/util/scripting-engines/trace-event-python.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
> index 40a815a5360b..a22ab53788bf 100644
> --- a/tools/perf/util/scripting-engines/trace-event-python.c
> +++ b/tools/perf/util/scripting-engines/trace-event-python.c
> @@ -649,6 +649,7 @@ static int python_generate_script(struct pevent *pevent, const char *outfile)
> fprintf(ofp, "%s=", f->name);
> if (f->flags & FIELD_IS_STRING ||
> f->flags & FIELD_IS_FLAG ||
> + f->flags & FIELD_IS_ARRAY ||
> f->flags & FIELD_IS_SYMBOLIC)
> fprintf(ofp, "%%s");
> else if (f->flags & FIELD_IS_SIGNED)
> --
> 1.9.2
>