[PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

[PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

[Punnaiah Choudary Kalluri]

Document device tree binding information as required by
the ZYNQ USB controller.

Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
---
Changes in v2:
- none
---
 .../devicetree/bindings/usb/ci-hdrc-zynq.txt       |   23 ++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt

diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
new file mode 100644
index 0000000..54bb3b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
@@ -0,0 +1,23 @@
+Xilinx Zynq usb controller based on synopsys usb IP(v2.20a)
+
+Required properties:
+- compatible:   should contain "xlnx,zynq-usb-2.20a"
+- clocks:       clock provider specifier
+- reg:          offset and length of the register set in the memory map
+- interrupt-parent: the phandle for the interrupt controller that services
+                    interrupts for this device.
+- interrupts:   interrupt-specifier for the controller interrupt.
+- phy_type:     should be "ulpi"
+- dr_mode:      should be "peripheral" or "host"
+
+Examples:
+
+	usb@e0002000 {
+		clocks = <&clkc 28>;
+		compatible = "xlnx,zynq-usb-2.20a";
+		dr_mode = "host";
+		interrupt-parent = <&ps7_scugic_0>;
+		interrupts = <0 21 4>;
+		phy_type = "ulpi";
+		reg = <0xe0002000 0x1000>;
+	} ;
-- 
1.7.4

Re: [PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

[Sergei Shtylyov]

Hello.

On 06/27/2014 03:23 PM, Punnaiah Choudary Kalluri wrote:

> Document device tree binding information as required by
> the ZYNQ USB controller.

> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
[...]

> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
> new file mode 100644
> index 0000000..54bb3b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
> @@ -0,0 +1,23 @@
> +Xilinx Zynq usb controller based on synopsys usb IP(v2.20a)

    s/usb/USB/.

> +
> +Required properties:
> +- compatible:   should contain "xlnx,zynq-usb-2.20a"
> +- clocks:       clock provider specifier
> +- reg:          offset and length of the register set in the memory map
> +- interrupt-parent: the phandle for the interrupt controller that services
> +                    interrupts for this device.

    This property has never been required -- it can be inherited from the 
upper level node.

WBR, Sergei

Re: [PATCH v2 1/2] usb: chipidea: zynq: Add device tree binding information

[punnaiah choudary kalluri]

On Fri, Jun 27, 2014 at 5:53 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
> On 06/27/2014 03:23 PM, Punnaiah Choudary Kalluri wrote:
>
>> Document device tree binding information as required by
>> the ZYNQ USB controller.
>
>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>
> [...]
>
>
>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
>> b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
>> new file mode 100644
>> index 0000000..54bb3b4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zynq.txt
>> @@ -0,0 +1,23 @@
>> +Xilinx Zynq usb controller based on synopsys usb IP(v2.20a)
>
>
>    s/usb/USB/.

OK

>
>
>> +
>> +Required properties:
>> +- compatible:   should contain "xlnx,zynq-usb-2.20a"
>> +- clocks:       clock provider specifier
>> +- reg:          offset and length of the register set in the memory map
>> +- interrupt-parent: the phandle for the interrupt controller that
>> services
>> +                    interrupts for this device.
>
>
>    This property has never been required -- it can be inherited from the
> upper level node.

OK. i will correct it.

Thanks,
Punnaiah

>
> WBR, Sergei
>
>