linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>,
	"Matthew Garrett" <matthew.garrett@nebula.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Valdis Kletnieks" <valdis.kletnieks@vt.edu>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Sonal Santan <sonal.santan@gmail.com>
Subject: Re: [PATCH v2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell
Date: Sat, 28 Jun 2014 19:12:17 -0700	[thread overview]
Message-ID: <53AF7601.5000205@infradead.org> (raw)
In-Reply-To: <1402473727-5464-1-git-send-email-pali.rohar@gmail.com>

Hi,

This should really be done as 2 separate patches:
One to move/rename the file and one to make the changes/additions
to it for DELL.

Can you resend it as 2 patches like that, please?

Thanks... and sorry for the delay.


On 06/11/14 01:02, Pali Rohár wrote:
> Dell kernel driver dell-smo8800 provides same freefall interface as hp_accel so
> program hpfall.c works also on Dell laptops. So rename it to freefall.c.
> 
> Dell driver does not provide hp::hddprotect led so make sure that freefall.c
> works also if hp::hddprotect does not exist in sysfs.
> 
> Additionally write info to syslog.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Cc: Sonal Santan <sonal.santan@gmail.com>
> ---
> Changes since v1:
> * Fixed warnings: Missing a blank line after declarations
> ---
>  Documentation/laptops/00-INDEX   |    4 +-
>  Documentation/laptops/freefall.c |  177 ++++++++++++++++++++++++++++++++++++++
>  Documentation/laptops/hpfall.c   |  146 -------------------------------
>  3 files changed, 179 insertions(+), 148 deletions(-)
>  create mode 100644 Documentation/laptops/freefall.c
>  delete mode 100644 Documentation/laptops/hpfall.c


-- 
~Randy

  parent reply	other threads:[~2014-06-29  2:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-03 10:47 [PATCH 0/2] Dell Latitude freefall driver (ACPI SMO8800/SMO8810) Pali Rohár
2014-05-03 10:47 ` [PATCH 1/2] platform: x86: dell-smo8800: " Pali Rohár
2014-05-07 16:29   ` One Thousand Gnomes
2014-05-20  7:00   ` Valdis.Kletnieks
2014-05-20  8:56     ` Pali Rohár
2014-05-20 18:02       ` Valdis.Kletnieks
2014-05-20 18:10         ` Pali Rohár
2014-05-20 18:36           ` Valdis.Kletnieks
2014-05-22 11:15   ` [PATCH v2] " Pali Rohár
2014-05-28 13:31     ` Pali Rohár
2014-06-06 10:24       ` Pali Rohár
2014-05-03 10:47 ` [PATCH 2/2] Documentation: Rename hpfall.c => freefall.c, fixes for Dell Pali Rohár
2014-06-11  8:02   ` [PATCH v2] " Pali Rohár
2014-06-14  8:53     ` Pavel Machek
2014-06-16 11:55       ` Pali Rohár
2014-06-27 19:08         ` Pali Rohár
2014-06-27 20:25           ` Randy Dunlap
2014-06-29  2:12     ` Randy Dunlap [this message]
2014-07-07 18:15       ` Pali Rohár
2014-07-08 22:49         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AF7601.5000205@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sonal.santan@gmail.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).