From: Lars-Peter Clausen <lars@metafoo.de>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove
Date: Sun, 29 Jun 2014 09:55:56 +0200 [thread overview]
Message-ID: <53AFC68C.5010105@metafoo.de> (raw)
In-Reply-To: <1404026663-3510-1-git-send-email-fabf@skynet.be>
On 06/29/2014 09:24 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> arch/mips/jz4740/clock-debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/jz4740/clock-debugfs.c b/arch/mips/jz4740/clock-debugfs.c
> index a8acdef..325422d0 100644
> --- a/arch/mips/jz4740/clock-debugfs.c
> +++ b/arch/mips/jz4740/clock-debugfs.c
> @@ -87,8 +87,7 @@ void jz4740_clock_debugfs_add_clk(struct clk *clk)
> /* TODO: Locking */
> void jz4740_clock_debugfs_update_parent(struct clk *clk)
> {
> - if (clk->debugfs_parent_entry)
> - debugfs_remove(clk->debugfs_parent_entry);
> + debugfs_remove(clk->debugfs_parent_entry);
>
> if (clk->parent) {
> char parent_path[100];
>
prev parent reply other threads:[~2014-06-29 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 7:24 [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove Fabian Frederick
2014-06-29 7:55 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AFC68C.5010105@metafoo.de \
--to=lars@metafoo.de \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox