* [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove
@ 2014-06-29 7:24 Fabian Frederick
2014-06-29 7:55 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-29 7:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Ralf Baechle, linux-mips
Fix checkpatch warning:
WARNING: debugfs_remove(NULL) is safe this check is probably not required
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
arch/mips/jz4740/clock-debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/jz4740/clock-debugfs.c b/arch/mips/jz4740/clock-debugfs.c
index a8acdef..325422d0 100644
--- a/arch/mips/jz4740/clock-debugfs.c
+++ b/arch/mips/jz4740/clock-debugfs.c
@@ -87,8 +87,7 @@ void jz4740_clock_debugfs_add_clk(struct clk *clk)
/* TODO: Locking */
void jz4740_clock_debugfs_update_parent(struct clk *clk)
{
- if (clk->debugfs_parent_entry)
- debugfs_remove(clk->debugfs_parent_entry);
+ debugfs_remove(clk->debugfs_parent_entry);
if (clk->parent) {
char parent_path[100];
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove
2014-06-29 7:24 [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove Fabian Frederick
@ 2014-06-29 7:55 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2014-06-29 7:55 UTC (permalink / raw)
To: Fabian Frederick, linux-kernel; +Cc: Ralf Baechle, linux-mips
On 06/29/2014 09:24 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> arch/mips/jz4740/clock-debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/jz4740/clock-debugfs.c b/arch/mips/jz4740/clock-debugfs.c
> index a8acdef..325422d0 100644
> --- a/arch/mips/jz4740/clock-debugfs.c
> +++ b/arch/mips/jz4740/clock-debugfs.c
> @@ -87,8 +87,7 @@ void jz4740_clock_debugfs_add_clk(struct clk *clk)
> /* TODO: Locking */
> void jz4740_clock_debugfs_update_parent(struct clk *clk)
> {
> - if (clk->debugfs_parent_entry)
> - debugfs_remove(clk->debugfs_parent_entry);
> + debugfs_remove(clk->debugfs_parent_entry);
>
> if (clk->parent) {
> char parent_path[100];
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-29 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-29 7:24 [PATCH 1/1] MIPS: jz4740: remove unnecessary null test before debugfs_remove Fabian Frederick
2014-06-29 7:55 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox