From: Martin Kepplinger <martink@posteo.de>
To: rui.zhang@intel.com
Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix backlight control for Acer TravelMate B113
Date: Sun, 29 Jun 2014 10:42:21 +0200 [thread overview]
Message-ID: <53AFD16D.10209@posteo.de> (raw)
In-Reply-To: <1403555446-16863-1-git-send-email-martink@posteo.de>
Am 2014-06-23 22:30, schrieb Martin Kepplinger:
> Fix backlight control for Acer TravelMate B113 Laptop by adding
> it to the video_dmi_table.
>
> A workaround before that was to use acpi_osi=Linux or
> acpi_backlight=vendor on boot but even then, only the function-
> keys worked.
>
> With this change there is no need for boot parameters and DE's
> controls work as well.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Tested-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/acpi/video.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index f8bc5a7..acb0670 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -528,6 +528,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
> },
> },
> {
> + .callback = video_set_use_native_backlight,
> + .ident = "Acer TravelMate B113",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate B113"),
> + },
> + },
> + {
> .callback = video_set_use_native_backlight,
> .ident = "HP ProBook 4340s",
> .matches = {
>
are there objections or advice on this? this would be really good to
have, even if for 3.17.
thanks.
martin
next prev parent reply other threads:[~2014-06-29 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 20:30 [PATCH] Fix backlight control for Acer TravelMate B113 Martin Kepplinger
2014-06-29 8:42 ` Martin Kepplinger [this message]
2014-06-30 1:29 ` Aaron Lu
2014-06-30 8:00 ` Martin Kepplinger
2014-07-07 12:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AFD16D.10209@posteo.de \
--to=martink@posteo.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).