From: Thomas Hellstrom <thellstrom@vmware.com>
To: Christopher Friedt <chrisfriedt@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@gmail.com>,
linux-graphics-maintainer@vmware.com
Subject: Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length
Date: Mon, 30 Jun 2014 13:48:46 +0200 [thread overview]
Message-ID: <53B14E9E.3040505@vmware.com> (raw)
In-Reply-To: <CAF4BF-Rmxqbbd_xroQbRTWeE2NfKAZm=Jm7SG2bNppHV2odYNA@mail.gmail.com>
On 06/30/2014 12:19 PM, Christopher Friedt wrote:
>
>
> On Apr 1, 2014 6:00 AM, "Thomas Hellstrom" <thellstrom@vmware.com
> <mailto:thellstrom@vmware.com>> wrote:
> >
> > On 03/28/2014 02:45 AM, Dave Airlie wrote:
> > > On Fri, Mar 28, 2014 at 10:45 AM, Christopher Friedt
> > > <chrisfriedt@gmail.com <mailto:chrisfriedt@gmail.com>> wrote:
> > >> Previously, the vmwgfx_fb driver would allow users to call
> FBIOSET_VINFO, but it would not adjust
> > >> the FINFO properly, resulting in distorted screen rendering. The
> patch corrects that behaviour.
> > >>
> > >> See https://bugs.gentoo.org/show_bug.cgi?id=494794
> <https://urldefense.proofpoint.com/v1/url?u=https://bugs.gentoo.org/show_bug.cgi?id%3D494794&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=hjf3nJVkhVmtW5ub%2FB2AFpKE1pI6pdX%2FvGBFan6861g%3D%0A&s=ca98e09efe2b59ab77e21ab77663e91400437f93d391e28139cb49aa0e21948c>
> for examples.
>
> This correction in vmwgfx appears to have triggered a bug in
> xorg-video-vmware on Ubuntu systems with a custom / unreleased kernel.
>
> If anyone from the X community does not step in, I'll take a look at
> it today.
>
> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vmware/+bug/1328898
> <https://urldefense.proofpoint.com/v1/url?u=https://bugs.launchpad.net/ubuntu/%2Bsource/xserver-xorg-video-vmware/%2Bbug/1328898&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=l5Ago9ekmVFZ3c4M6eauqrJWGwjf6fTb%2BP3CxbBFkVM%3D%0A&m=hjf3nJVkhVmtW5ub%2FB2AFpKE1pI6pdX%2FvGBFan6861g%3D%0A&s=56cf4e2efa552bd5eaa2fe7cd82af3f561d717bdd9b6745c84451e1ab6bd05d1>
>
> https://communities.vmware.com/message/2388776
>
+ vmware maintainers
I don't think we can blame video-vmware for this. A kernel driver change
that breaks existing user-space is by definition a kernel driver bug,
regardless whether exisiting user-space is doing something horrendously
stupid.
So the fix must IMO be a kernel driver fix. My initial guess is that
once we set the bytes per line register, it might not be automatically
updated when the screen width is changed, but the documentation is poor.
I see if I can shed some light over this.
/Thomas
next prev parent reply other threads:[~2014-06-30 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 0:45 [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length Christopher Friedt
2014-03-28 0:48 ` Christopher Friedt
2014-03-28 1:45 ` Dave Airlie
2014-04-01 10:00 ` Thomas Hellstrom
[not found] ` <CAF4BF-Rmxqbbd_xroQbRTWeE2NfKAZm=Jm7SG2bNppHV2odYNA@mail.gmail.com>
2014-06-30 11:48 ` Thomas Hellstrom [this message]
2014-06-30 12:25 ` Christopher Friedt
2014-06-30 12:39 ` Thomas Hellstrom
2014-06-30 12:49 ` Christopher Friedt
2014-06-30 13:03 ` Thomas Hellstrom
2014-06-30 13:18 ` Christopher Friedt
2014-06-30 13:22 ` Thomas Hellstrom
2014-07-02 3:01 ` Christopher Friedt
2014-07-02 4:16 ` Thomas Hellstrom
[not found] ` <CAF4BF-SZp64iD_imNH42qXaENWbNzgBOiVaSeUMMBScrSc6VEw@mail.gmail.com>
2014-07-02 22:19 ` Christopher Friedt
-- strict thread matches above, loose matches on Subject: below --
2014-02-01 15:26 Christopher Friedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B14E9E.3040505@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@gmail.com \
--cc=chrisfriedt@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox