* [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove_recursive
@ 2014-06-29 7:16 Fabian Frederick
2014-06-30 17:11 ` David Daney
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-29 7:16 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Ralf Baechle, linux-mips
Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
arch/mips/cavium-octeon/oct_ilm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/cavium-octeon/oct_ilm.c b/arch/mips/cavium-octeon/oct_ilm.c
index 71b213d..2d68a39 100644
--- a/arch/mips/cavium-octeon/oct_ilm.c
+++ b/arch/mips/cavium-octeon/oct_ilm.c
@@ -194,8 +194,7 @@ err_irq:
static __exit void oct_ilm_module_exit(void)
{
disable_timer(TIMER_NUM);
- if (dir)
- debugfs_remove_recursive(dir);
+ debugfs_remove_recursive(dir);
free_irq(OCTEON_IRQ_TIMER0 + TIMER_NUM, 0);
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove_recursive
2014-06-29 7:16 [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
@ 2014-06-30 17:11 ` David Daney
0 siblings, 0 replies; 2+ messages in thread
From: David Daney @ 2014-06-30 17:11 UTC (permalink / raw)
To: Fabian Frederick, Ralf Baechle; +Cc: linux-kernel, linux-mips
On 06/29/2014 12:16 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
I haven't tested it, but it seems fine, so...
Acked-by: David Daney <david.daney@cavium.com>
> ---
> arch/mips/cavium-octeon/oct_ilm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/oct_ilm.c b/arch/mips/cavium-octeon/oct_ilm.c
> index 71b213d..2d68a39 100644
> --- a/arch/mips/cavium-octeon/oct_ilm.c
> +++ b/arch/mips/cavium-octeon/oct_ilm.c
> @@ -194,8 +194,7 @@ err_irq:
> static __exit void oct_ilm_module_exit(void)
> {
> disable_timer(TIMER_NUM);
> - if (dir)
> - debugfs_remove_recursive(dir);
> + debugfs_remove_recursive(dir);
> free_irq(OCTEON_IRQ_TIMER0 + TIMER_NUM, 0);
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-30 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-29 7:16 [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
2014-06-30 17:11 ` David Daney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox