* [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 @ 2014-07-01 0:40 Chanwoo Choi 2014-07-01 3:33 ` Sachin Kamat 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2014-07-01 0:40 UTC (permalink / raw) To: kgene.kim Cc: t.figa, ben-linux, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, kyungmin.park, linux, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc, Chanwoo Choi This patch add TMU (Thermal Management Unit) dt node to monitor the high temperature for Exynos3250. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> --- This patch has a dependency on following patch [1]: [1] https://lkml.org/lkml/2014/6/30/805 arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 3660cab..1e566af 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -192,6 +192,16 @@ status = "disabled"; }; + tmu: tmu@100C0000 { + compatible = "samsung,exynos3250-tmu"; + interrupt-parent = <&gic>; + reg = <0x100C0000 0x100>; + interrupts = <0 216 0>; + clocks = <&cmu CLK_TMU_APBIF>; + clock-names = "tmu_apbif"; + status = "disabled"; + }; + gic: interrupt-controller@10481000 { compatible = "arm,cortex-a15-gic"; #interrupt-cells = <3>; -- 1.8.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-01 0:40 [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 Chanwoo Choi @ 2014-07-01 3:33 ` Sachin Kamat 2014-07-01 4:04 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Sachin Kamat @ 2014-07-01 3:33 UTC (permalink / raw) To: Chanwoo Choi Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc Hi Chanwoo, On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > This patch add TMU (Thermal Management Unit) dt node to monitor the high > temperature for Exynos3250. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > This patch has a dependency on following patch [1]: > [1] https://lkml.org/lkml/2014/6/30/805 > > arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 3660cab..1e566af 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -192,6 +192,16 @@ > status = "disabled"; > }; > > + tmu: tmu@100C0000 { > + compatible = "samsung,exynos3250-tmu"; > + interrupt-parent = <&gic>; > + reg = <0x100C0000 0x100>; > + interrupts = <0 216 0>; > + clocks = <&cmu CLK_TMU_APBIF>; > + clock-names = "tmu_apbif"; > + status = "disabled"; I don't think there would be any board specific properties needed. Hence leave the status as enabled (by deleting the above line). -- Regards, Sachin. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-01 3:33 ` Sachin Kamat @ 2014-07-01 4:04 ` Chanwoo Choi 2014-07-01 4:10 ` Sachin Kamat 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2014-07-01 4:04 UTC (permalink / raw) To: Sachin Kamat Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc Hi Sachin, On 07/01/2014 12:33 PM, Sachin Kamat wrote: > Hi Chanwoo, > > On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> This patch add TMU (Thermal Management Unit) dt node to monitor the high >> temperature for Exynos3250. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> This patch has a dependency on following patch [1]: >> [1] https://lkml.org/lkml/2014/6/30/805 >> >> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 3660cab..1e566af 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -192,6 +192,16 @@ >> status = "disabled"; >> }; >> >> + tmu: tmu@100C0000 { >> + compatible = "samsung,exynos3250-tmu"; >> + interrupt-parent = <&gic>; >> + reg = <0x100C0000 0x100>; >> + interrupts = <0 216 0>; >> + clocks = <&cmu CLK_TMU_APBIF>; >> + clock-names = "tmu_apbif"; >> + status = "disabled"; > > I don't think there would be any board specific properties needed. Hence > leave the status as enabled (by deleting the above line). > I think that if specific board need TMU feature, dts file for specific board should include tmu dt node with 'okay' status. The specific board based on Exynos3250 might not need TMU feature. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-01 4:04 ` Chanwoo Choi @ 2014-07-01 4:10 ` Sachin Kamat 2014-07-01 23:52 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Sachin Kamat @ 2014-07-01 4:10 UTC (permalink / raw) To: Chanwoo Choi Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc Hi Chanwoo, On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Sachin, > > On 07/01/2014 12:33 PM, Sachin Kamat wrote: >> Hi Chanwoo, >> >> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>> temperature for Exynos3250. >>> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >>> --- >>> This patch has a dependency on following patch [1]: >>> [1] https://lkml.org/lkml/2014/6/30/805 >>> >>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>> index 3660cab..1e566af 100644 >>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>> @@ -192,6 +192,16 @@ >>> status = "disabled"; >>> }; >>> >>> + tmu: tmu@100C0000 { >>> + compatible = "samsung,exynos3250-tmu"; >>> + interrupt-parent = <&gic>; >>> + reg = <0x100C0000 0x100>; >>> + interrupts = <0 216 0>; >>> + clocks = <&cmu CLK_TMU_APBIF>; >>> + clock-names = "tmu_apbif"; >>> + status = "disabled"; >> >> I don't think there would be any board specific properties needed. Hence >> leave the status as enabled (by deleting the above line). >> > > I think that if specific board need TMU feature, dts file for specific board > should include tmu dt node with 'okay' status. The specific board based on > Exynos3250 might not need TMU feature. The status field in DT node is not meant for stating the build configuration but represents the readiness of the hardware for usage on the platform. If a particular board does not need this feature it needs to be disabled in the build config and only for any special requirements disable it in board file. -- Regards, Sachin. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-01 4:10 ` Sachin Kamat @ 2014-07-01 23:52 ` Chanwoo Choi 2014-07-02 3:09 ` Sachin Kamat 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2014-07-01 23:52 UTC (permalink / raw) To: Sachin Kamat Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc On 07/01/2014 01:10 PM, Sachin Kamat wrote: > Hi Chanwoo, > > On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi Sachin, >> >> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>> temperature for Exynos3250. >>>> >>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >>>> --- >>>> This patch has a dependency on following patch [1]: >>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>> >>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>> index 3660cab..1e566af 100644 >>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>> @@ -192,6 +192,16 @@ >>>> status = "disabled"; >>>> }; >>>> >>>> + tmu: tmu@100C0000 { >>>> + compatible = "samsung,exynos3250-tmu"; >>>> + interrupt-parent = <&gic>; >>>> + reg = <0x100C0000 0x100>; >>>> + interrupts = <0 216 0>; >>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>> + clock-names = "tmu_apbif"; >>>> + status = "disabled"; >>> >>> I don't think there would be any board specific properties needed. Hence >>> leave the status as enabled (by deleting the above line). >>> >> >> I think that if specific board need TMU feature, dts file for specific board >> should include tmu dt node with 'okay' status. The specific board based on >> Exynos3250 might not need TMU feature. > > The status field in DT node is not meant for stating the build configuration but > represents the readiness of the hardware for usage on the platform. If > a particular > board does not need this feature it needs to be disabled in the build > config and only > for any special requirements disable it in board file. TMU (Thermal Management Unit) needs specific regulator for TMU power as following: The regulator for TMU is dependent on board. For exmaple: in board dts file including tmu dt &tmu { vtmu-supply = <&ldo7_reg>; status = "okay"; }; ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-01 23:52 ` Chanwoo Choi @ 2014-07-02 3:09 ` Sachin Kamat 2014-07-02 4:27 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Sachin Kamat @ 2014-07-02 3:09 UTC (permalink / raw) To: Chanwoo Choi Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > On 07/01/2014 01:10 PM, Sachin Kamat wrote: >> Hi Chanwoo, >> >> On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>> Hi Sachin, >>> >>> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>>> Hi Chanwoo, >>>> >>>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>>> temperature for Exynos3250. >>>>> >>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >>>>> --- >>>>> This patch has a dependency on following patch [1]: >>>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>>> >>>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>>> 1 file changed, 10 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>>> index 3660cab..1e566af 100644 >>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>>> @@ -192,6 +192,16 @@ >>>>> status = "disabled"; >>>>> }; >>>>> >>>>> + tmu: tmu@100C0000 { >>>>> + compatible = "samsung,exynos3250-tmu"; >>>>> + interrupt-parent = <&gic>; >>>>> + reg = <0x100C0000 0x100>; >>>>> + interrupts = <0 216 0>; >>>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>>> + clock-names = "tmu_apbif"; >>>>> + status = "disabled"; >>>> >>>> I don't think there would be any board specific properties needed. Hence >>>> leave the status as enabled (by deleting the above line). >>>> >>> >>> I think that if specific board need TMU feature, dts file for specific board >>> should include tmu dt node with 'okay' status. The specific board based on >>> Exynos3250 might not need TMU feature. >> >> The status field in DT node is not meant for stating the build configuration but >> represents the readiness of the hardware for usage on the platform. If >> a particular >> board does not need this feature it needs to be disabled in the build >> config and only >> for any special requirements disable it in board file. > > TMU (Thermal Management Unit) needs specific regulator for TMU power as following: > The regulator for TMU is dependent on board. In this case it makes sense to leave it disabled in dtsi. -- Regards, Sachin. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 2014-07-02 3:09 ` Sachin Kamat @ 2014-07-02 4:27 ` Chanwoo Choi 0 siblings, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2014-07-02 4:27 UTC (permalink / raw) To: Sachin Kamat Cc: Kukjin Kim, Tomasz Figa, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Russell King, open list:OPEN FIRMWARE AND..., open list, linux-arm-kernel@lists.infradead.org, linux-samsung-soc Hi Sachin, On 07/02/2014 12:09 PM, Sachin Kamat wrote: > On Wed, Jul 2, 2014 at 5:22 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> On 07/01/2014 01:10 PM, Sachin Kamat wrote: >>> Hi Chanwoo, >>> >>> On Tue, Jul 1, 2014 at 9:34 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>>> Hi Sachin, >>>> >>>> On 07/01/2014 12:33 PM, Sachin Kamat wrote: >>>>> Hi Chanwoo, >>>>> >>>>> On Tue, Jul 1, 2014 at 6:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >>>>>> This patch add TMU (Thermal Management Unit) dt node to monitor the high >>>>>> temperature for Exynos3250. >>>>>> >>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>>>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >>>>>> --- >>>>>> This patch has a dependency on following patch [1]: >>>>>> [1] https://lkml.org/lkml/2014/6/30/805 >>>>>> >>>>>> arch/arm/boot/dts/exynos3250.dtsi | 10 ++++++++++ >>>>>> 1 file changed, 10 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >>>>>> index 3660cab..1e566af 100644 >>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi >>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi >>>>>> @@ -192,6 +192,16 @@ >>>>>> status = "disabled"; >>>>>> }; >>>>>> >>>>>> + tmu: tmu@100C0000 { >>>>>> + compatible = "samsung,exynos3250-tmu"; >>>>>> + interrupt-parent = <&gic>; >>>>>> + reg = <0x100C0000 0x100>; >>>>>> + interrupts = <0 216 0>; >>>>>> + clocks = <&cmu CLK_TMU_APBIF>; >>>>>> + clock-names = "tmu_apbif"; >>>>>> + status = "disabled"; >>>>> >>>>> I don't think there would be any board specific properties needed. Hence >>>>> leave the status as enabled (by deleting the above line). >>>>> >>>> >>>> I think that if specific board need TMU feature, dts file for specific board >>>> should include tmu dt node with 'okay' status. The specific board based on >>>> Exynos3250 might not need TMU feature. >>> >>> The status field in DT node is not meant for stating the build configuration but >>> represents the readiness of the hardware for usage on the platform. If >>> a particular >>> board does not need this feature it needs to be disabled in the build >>> config and only >>> for any special requirements disable it in board file. >> >> TMU (Thermal Management Unit) needs specific regulator for TMU power as following: >> The regulator for TMU is dependent on board. > > In this case it makes sense to leave it disabled in dtsi. > Thanks for your review. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-02 4:28 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-01 0:40 [PATCH] ARM: dts: Add TMU dt node to monitor the temperature for Exynos3250 Chanwoo Choi 2014-07-01 3:33 ` Sachin Kamat 2014-07-01 4:04 ` Chanwoo Choi 2014-07-01 4:10 ` Sachin Kamat 2014-07-01 23:52 ` Chanwoo Choi 2014-07-02 3:09 ` Sachin Kamat 2014-07-02 4:27 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox