From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371AbaGBPCp (ORCPT ); Wed, 2 Jul 2014 11:02:45 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:55464 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbaGBPCn (ORCPT ); Wed, 2 Jul 2014 11:02:43 -0400 Message-ID: <53B41F0E.90107@ti.com> Date: Wed, 2 Jul 2014 10:02:38 -0500 From: Dan Murphy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Daniel Mack , CC: , , , Subject: Re: [alsa-devel] [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier References: <1404307852-10456-1-git-send-email-dmurphy@ti.com> <53B40D55.6000602@zonque.org> In-Reply-To: <53B40D55.6000602@zonque.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Thanks for the review On 07/02/2014 08:47 AM, Daniel Mack wrote: > Hi Dan, > > On 07/02/2014 03:30 PM, Dan Murphy wrote: >> + if (np) { >> + data->power_gpio = of_get_named_gpio(np, "enable-gpio", 0); >> + } else if (pdata) { >> + data->power_gpio = pdata->enable_gpio; >> + } else { >> + dev_err(dev, "Platform or dev tree data not set\n"); >> + return -ENODEV; >> + } > New code for GPIO handling should use the new gpiod interface. > See include/linux/gpio/consumer.h, or the sta350 codec driver. OK good catch. I will look into it. Does the gpiod interface handle both pdata as well as dt? > For that to work, you also need to rename the property to > 'enable-gpios', even though there's only one. I am looking for that restriction in the code. But don't see it. Will dig some more here. > > > Daniel > -- ------------------ Dan Murphy